Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
index 7e4476377adff21541a491af3953cefe7b108a08..56fe72273b4cc006b94ad9d1fcaad77b5063d270 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
@@ -26,6 +26,7 @@
#include "core/CoreExport.h"
#include "core/html/HTMLFrameOwnerElement.h"
+#include "platform/bindings/ActiveScriptWrappable.h"
#include "platform/bindings/SharedPersistent.h"
#include "v8/include/v8.h"
@@ -41,11 +42,17 @@ enum PreferPlugInsForImagesOption {
kShouldNotPreferPlugInsForImages
};
-class CORE_EXPORT HTMLPlugInElement : public HTMLFrameOwnerElement {
+class CORE_EXPORT HTMLPlugInElement
+ : public HTMLFrameOwnerElement,
+ public ActiveScriptWrappable<HTMLPlugInElement> {
+ USING_GARBAGE_COLLECTED_MIXIN(HTMLPlugInElement);
+
public:
~HTMLPlugInElement() override;
DECLARE_VIRTUAL_TRACE();
+ bool HasPendingActivity() const final;
+
void SetFocused(bool, WebFocusType) override;
void ResetInstance();
// TODO(dcheng): Consider removing this, since HTMLEmbedElementLegacyCall
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLObjectElement.idl ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698