third_party/WebKit/Source/core/html/HTMLMediaElement.h - Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

index 563d26bb06722690d391ac68946b168884d883a8..92249d89df1e34245a58891c6cbd75dc62236957 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h

@@ -290,7 +290,7 @@ class CORE_EXPORT HTMLMediaElement

void SourceWasAdded(HTMLSourceElement*);

// ScriptWrappable functions.

- bool HasPendingActivity() const final;

+ bool HasPendingActivity() const override;

AudioSourceProviderClient* AudioSourceNode() { return audio_source_node_; }

void SetAudioSourceNode(AudioSourceProviderClient*);