third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)

Patch Set: Leak Expectation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index a3466a06728f0d90d5f9c40b17fdf6c67cb4c2d1..c5617d97380677f60eb37b5e3fd1ebc7d8f4786e 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -95,6 +95,10 @@ DEFINE_TRACE(HTMLVideoElement) {

HTMLMediaElement::Trace(visitor);

}

+bool HTMLVideoElement::HasPendingActivityInternal() const {

+ return image_loader_ && image_loader_->HasPendingActivity();

Node::InsertionNotificationRequest HTMLVideoElement::InsertedInto(

ContainerNode* insertion_point) {

if (insertion_point->isConnected() && custom_controls_fullscreen_detector_)