third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)

Patch Set: Leak Expectation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index b92ac1bcfeb61c2c162d02c210672c1e7cc8a79a..b0e6761547ba337aeb9d59880d988480b75e836b 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -96,6 +96,10 @@ DEFINE_TRACE(HTMLPlugInElement) {

HTMLFrameOwnerElement::Trace(visitor);

}

+bool HTMLPlugInElement::HasPendingActivity() const {

+ return image_loader_ && image_loader_->HasPendingActivity();

void HTMLPlugInElement::SetPersistedPlugin(PluginView* plugin) {

if (persisted_plugin_ == plugin)

return;