third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)

Patch Set: Leak Expectation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index d88856ddeffcdc4a47c7bec3675a5e1801cd5b09..f41e611c6f2ece8ee6fb388831579fe31aee923a 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -3421,6 +3421,9 @@ void HTMLMediaElement::ContextDestroyed(ExecutionContext*) {

}

bool HTMLMediaElement::HasPendingActivity() const {

+ if (HasPendingActivityInternal())

+ return true;

// The delaying-the-load-event flag is set by resource selection algorithm

// when looking for a resource to load, before networkState has reached to

// kNetworkLoading.