third_party/WebKit/Source/core/html/HTMLEmbedElement.idl - Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLEmbedElement.idl

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)

Patch Set: Leak Expectation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLEmbedElement.idl

diff --git a/third_party/WebKit/Source/core/html/HTMLEmbedElement.idl b/third_party/WebKit/Source/core/html/HTMLEmbedElement.idl

index 91d2e6c378c60ba5ab4ecf3e4326e8d6df2c845e..29ff386eadb2227a3ab4dacdb359c0ac6b1c32ec 100644

--- a/third_party/WebKit/Source/core/html/HTMLEmbedElement.idl

+++ b/third_party/WebKit/Source/core/html/HTMLEmbedElement.idl

@@ -23,6 +23,7 @@

// TODO(yukishiino): HTMLEmbedElement should not have [OverrideBuiltins].

[

OverrideBuiltins,

+ ActiveScriptWrappable,

] interface HTMLEmbedElement : HTMLElement {

[CEReactions, Reflect, URL] attribute DOMString src;

[CEReactions, Reflect] attribute DOMString type;