Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGImageElement.h

Issue 2905233002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #ifndef SVGImageElement_h 21 #ifndef SVGImageElement_h
22 #define SVGImageElement_h 22 #define SVGImageElement_h
23 23
24 #include "core/html/canvas/ImageElementBase.h" 24 #include "core/html/canvas/ImageElementBase.h"
25 #include "core/svg/SVGAnimatedLength.h" 25 #include "core/svg/SVGAnimatedLength.h"
26 #include "core/svg/SVGAnimatedPreserveAspectRatio.h" 26 #include "core/svg/SVGAnimatedPreserveAspectRatio.h"
27 #include "core/svg/SVGGraphicsElement.h" 27 #include "core/svg/SVGGraphicsElement.h"
28 #include "core/svg/SVGImageLoader.h" 28 #include "core/svg/SVGImageLoader.h"
29 #include "core/svg/SVGURIReference.h" 29 #include "core/svg/SVGURIReference.h"
30 #include "platform/bindings/ActiveScriptWrappable.h"
30 #include "platform/heap/Handle.h" 31 #include "platform/heap/Handle.h"
31 32
32 namespace blink { 33 namespace blink {
33 34
34 class CORE_EXPORT SVGImageElement final : public SVGGraphicsElement, 35 class CORE_EXPORT SVGImageElement final
35 public ImageElementBase, 36 : public SVGGraphicsElement,
36 public SVGURIReference { 37 public ImageElementBase,
38 public SVGURIReference,
39 public ActiveScriptWrappable<SVGImageElement> {
37 DEFINE_WRAPPERTYPEINFO(); 40 DEFINE_WRAPPERTYPEINFO();
38 USING_GARBAGE_COLLECTED_MIXIN(SVGImageElement); 41 USING_GARBAGE_COLLECTED_MIXIN(SVGImageElement);
39 42
40 public: 43 public:
41 DECLARE_NODE_FACTORY(SVGImageElement); 44 DECLARE_NODE_FACTORY(SVGImageElement);
42 DECLARE_VIRTUAL_TRACE(); 45 DECLARE_VIRTUAL_TRACE();
43 46
44 bool CurrentFrameHasSingleSecurityOrigin() const; 47 bool CurrentFrameHasSingleSecurityOrigin() const;
45 48
46 SVGAnimatedLength* x() const { return x_.Get(); } 49 SVGAnimatedLength* x() const { return x_.Get(); }
47 SVGAnimatedLength* y() const { return y_.Get(); } 50 SVGAnimatedLength* y() const { return y_.Get(); }
48 SVGAnimatedLength* width() const { return width_.Get(); } 51 SVGAnimatedLength* width() const { return width_.Get(); }
49 SVGAnimatedLength* height() const { return height_.Get(); } 52 SVGAnimatedLength* height() const { return height_.Get(); }
50 SVGAnimatedPreserveAspectRatio* preserveAspectRatio() { 53 SVGAnimatedPreserveAspectRatio* preserveAspectRatio() {
51 return preserve_aspect_ratio_.Get(); 54 return preserve_aspect_ratio_.Get();
52 } 55 }
53 56
57 bool HasPendingActivity() const final {
58 return GetImageLoader().HasPendingActivity();
59 }
60
54 // Exposed for testing. 61 // Exposed for testing.
55 ImageResourceContent* CachedImage() const { 62 ImageResourceContent* CachedImage() const {
56 return GetImageLoader().GetImage(); 63 return GetImageLoader().GetImage();
57 } 64 }
58 65
59 private: 66 private:
60 explicit SVGImageElement(Document&); 67 explicit SVGImageElement(Document&);
61 68
62 bool IsStructurallyExternal() const override { 69 bool IsStructurallyExternal() const override {
63 return !HrefString().IsNull(); 70 return !HrefString().IsNull();
(...skipping 24 matching lines...) Expand all
88 Member<SVGAnimatedLength> width_; 95 Member<SVGAnimatedLength> width_;
89 Member<SVGAnimatedLength> height_; 96 Member<SVGAnimatedLength> height_;
90 Member<SVGAnimatedPreserveAspectRatio> preserve_aspect_ratio_; 97 Member<SVGAnimatedPreserveAspectRatio> preserve_aspect_ratio_;
91 98
92 Member<SVGImageLoader> image_loader_; 99 Member<SVGImageLoader> image_loader_;
93 }; 100 };
94 101
95 } // namespace blink 102 } // namespace blink
96 103
97 #endif // SVGImageElement_h 104 #endif // SVGImageElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/ImageLoader.cpp ('k') | third_party/WebKit/Source/core/svg/SVGImageElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698