Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: net/socket/tcp_socket_win.cc

Issue 2905183002: Remove deprecated NonThreadSafe usage in net\socket. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_socket_win.h ('k') | net/socket/udp_socket_posix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_socket_win.cc
diff --git a/net/socket/tcp_socket_win.cc b/net/socket/tcp_socket_win.cc
index f96d678c6aeed7ef3b7aa8ddcd25e0f05bcbe922..7b4072e7bdeda8a451164fde0cf4c0d6b642eeaf 100644
--- a/net/socket/tcp_socket_win.cc
+++ b/net/socket/tcp_socket_win.cc
@@ -259,12 +259,13 @@ TCPSocketWin::TCPSocketWin(
}
TCPSocketWin::~TCPSocketWin() {
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
Close();
net_log_.EndEvent(NetLogEventType::SOCKET_ALIVE);
}
int TCPSocketWin::Open(AddressFamily family) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_EQ(socket_, INVALID_SOCKET);
socket_ = CreatePlatformSocket(ConvertAddressFamily(family), SOCK_STREAM,
@@ -286,7 +287,7 @@ int TCPSocketWin::Open(AddressFamily family) {
int TCPSocketWin::AdoptConnectedSocket(SocketDescriptor socket,
const IPEndPoint& peer_address) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_EQ(socket_, INVALID_SOCKET);
DCHECK(!core_.get());
@@ -306,7 +307,7 @@ int TCPSocketWin::AdoptConnectedSocket(SocketDescriptor socket,
}
int TCPSocketWin::AdoptUnconnectedSocket(SocketDescriptor socket) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_EQ(socket_, INVALID_SOCKET);
socket_ = socket;
@@ -325,7 +326,7 @@ int TCPSocketWin::AdoptUnconnectedSocket(SocketDescriptor socket) {
}
int TCPSocketWin::Bind(const IPEndPoint& address) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_NE(socket_, INVALID_SOCKET);
SockaddrStorage storage;
@@ -343,7 +344,7 @@ int TCPSocketWin::Bind(const IPEndPoint& address) {
}
int TCPSocketWin::Listen(int backlog) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_GT(backlog, 0);
DCHECK_NE(socket_, INVALID_SOCKET);
DCHECK_EQ(accept_event_, WSA_INVALID_EVENT);
@@ -368,7 +369,7 @@ int TCPSocketWin::Listen(int backlog) {
int TCPSocketWin::Accept(std::unique_ptr<TCPSocketWin>* socket,
IPEndPoint* address,
const CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(socket);
DCHECK(address);
DCHECK(!callback.is_null());
@@ -393,7 +394,7 @@ int TCPSocketWin::Accept(std::unique_ptr<TCPSocketWin>* socket,
int TCPSocketWin::Connect(const IPEndPoint& address,
const CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_NE(socket_, INVALID_SOCKET);
DCHECK(!waiting_connect_);
@@ -426,7 +427,7 @@ int TCPSocketWin::Connect(const IPEndPoint& address,
}
bool TCPSocketWin::IsConnected() const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (socket_ == INVALID_SOCKET || waiting_connect_)
return false;
@@ -447,7 +448,7 @@ bool TCPSocketWin::IsConnected() const {
}
bool TCPSocketWin::IsConnectedAndIdle() const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (socket_ == INVALID_SOCKET || waiting_connect_)
return false;
@@ -471,7 +472,7 @@ bool TCPSocketWin::IsConnectedAndIdle() const {
int TCPSocketWin::Read(IOBuffer* buf,
int buf_len,
const CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(!core_->read_iobuffer_.get());
// base::Unretained() is safe because RetryRead() won't be called when |this|
// is gone.
@@ -489,7 +490,7 @@ int TCPSocketWin::Read(IOBuffer* buf,
int TCPSocketWin::ReadIfReady(IOBuffer* buf,
int buf_len,
const CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_NE(socket_, INVALID_SOCKET);
DCHECK(!waiting_read_);
DCHECK(read_if_ready_callback_.is_null());
@@ -523,7 +524,7 @@ int TCPSocketWin::ReadIfReady(IOBuffer* buf,
int TCPSocketWin::Write(IOBuffer* buf,
int buf_len,
const CompletionCallback& callback) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK_NE(socket_, INVALID_SOCKET);
DCHECK(!waiting_write_);
CHECK(write_callback_.is_null());
@@ -572,7 +573,7 @@ int TCPSocketWin::Write(IOBuffer* buf,
}
int TCPSocketWin::GetLocalAddress(IPEndPoint* address) const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(address);
SockaddrStorage storage;
@@ -587,7 +588,7 @@ int TCPSocketWin::GetLocalAddress(IPEndPoint* address) const {
}
int TCPSocketWin::GetPeerAddress(IPEndPoint* address) const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
DCHECK(address);
if (!IsConnected())
return ERR_SOCKET_NOT_CONNECTED;
@@ -631,12 +632,12 @@ int TCPSocketWin::SetExclusiveAddrUse() {
}
int TCPSocketWin::SetReceiveBufferSize(int32_t size) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
return SetSocketReceiveBufferSize(socket_, size);
}
int TCPSocketWin::SetSendBufferSize(int32_t size) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
return SetSocketSendBufferSize(socket_, size);
}
@@ -649,7 +650,7 @@ bool TCPSocketWin::SetNoDelay(bool no_delay) {
}
void TCPSocketWin::Close() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
if (socket_ != INVALID_SOCKET) {
// Only log the close event if there's actually a socket to close.
@@ -707,7 +708,7 @@ void TCPSocketWin::Close() {
}
void TCPSocketWin::DetachFromThread() {
- base::NonThreadSafe::DetachFromThread();
+ DETACH_FROM_THREAD(thread_checker_);
}
void TCPSocketWin::StartLoggingMultipleConnectAttempts(
« no previous file with comments | « net/socket/tcp_socket_win.h ('k') | net/socket/udp_socket_posix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698