Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2905163002: Perform type inference on redirecting initializers (`C() : this(...);`). (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Perform type inference on redirecting initializers (`C() : this(...);`). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ee6fd5e1a3e64c74012fa4fad0d78f642f648869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 3 chunks +42 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 3 chunks +18 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-25 21:38:41 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 21:42:28 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-25 21:47:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee6fd5e1a3e64c74012fa4fad0d78f642f648869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698