Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 290513003: Move UserContext to its own file (Closed)

Created:
6 years, 7 months ago by bartfab (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move UserContext to its own file This CL moves the UserContext from user.[cc|h] to its own header and implementation files. BUG=367847 TEST=Updated unit and browser tests TBR=nkostylev (chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc) TBR=nkostylev (chrome/browser/chromeos/chrome_browser_main_chromeos.cc) TBR=pamg (chrome/browser/managed_mode/chromeos/manager_password_service.[cc|h]) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271424

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -182 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/screenlock_private_apitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/auth_attempt_state.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/extended_authenticator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/extended_authenticator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/login_status_consumer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/mock_authenticator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/mock_login_status_consumer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/mock_login_status_consumer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/login/auth/user_context.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/user_context.cc View 1 1 chunk +122 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_authentication.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_login_flow.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_flow.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.cc View 1 2 chunks +0 lines, -111 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/managed_mode/chromeos/manager_password_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/managed_mode/chromeos/manager_password_service.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bartfab (slow)
Hi Denis, Could you take a look please?
6 years, 7 months ago (2014-05-15 13:57:26 UTC) #1
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 7 months ago (2014-05-15 14:19:19 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-19 13:11:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/290513003/10001
6 years, 7 months ago (2014-05-19 13:11:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 15:00:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 15:51:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154991)
6 years, 7 months ago (2014-05-19 15:51:53 UTC) #7
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-19 16:34:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/290513003/10001
6 years, 7 months ago (2014-05-19 16:34:28 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 18:09:13 UTC) #10
Message was sent while issue was closed.
Change committed as 271424

Powered by Google App Engine
This is Rietveld 408576698