Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 290513002: Expand C++ macros in tools/generate-runtime-tests.py to increase coverage (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Expand C++ macros in tools/generate-runtime-tests.py to increase coverage R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21340

Patch Set 1 #

Total comments: 1

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -83 lines) Patch
M src/runtime.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + test/mjsunit/runtime-gen/arraybufferviewgetbytelength.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/arraybufferviewgetbyteoffset.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetbuffer.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetfloat32.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetfloat64.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetint16.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetint32.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetint8.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetuint16.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetuint32.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewgetuint8.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/runtime-gen/dataviewinitialize.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetfloat32.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetfloat64.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetint16.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetint32.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetint8.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetuint16.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetuint32.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/dataviewsetuint8.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/mathacos.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/mathasin.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/mathatan.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/mathlogrt.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/typedarraygetlength.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 5 chunks +133 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Why add special cases for DATA_VIEW_GETTER when we can simply add a generic (first-order) macro ...
6 years, 7 months ago (2014-05-15 13:59:29 UTC) #1
Dmitry Lomov (no reviews)
lgtm
6 years, 7 months ago (2014-05-15 14:12:44 UTC) #2
Jakob Kummerow
6 years, 7 months ago (2014-05-16 13:16:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r21340 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698