Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2905123002: Perform type inference on explicitly typed fields. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -54 lines) Patch
M pkg/front_end/lib/src/fasta/builder/field_builder.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +13 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart.strong.expect View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future.dart.strong.expect View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future_or.dart.strong.expect View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_binary_custom.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_conditional.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_prefix_expression_custom.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_use_of_void.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_custom_binary_op.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_custom_binary_op_via_interface.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_custom_unary_op.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_custom_unary_op_via_interface.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_invoke_method.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_invoke_method_via_interface.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_function_typed_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_uses_synthetic_function_type_required_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_depends_on_args.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_field.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_independent_of_args_top_level.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/list_literals_top_level.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method_identifier_sequence.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/subexpressions_of_explicitly_typed_fields.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/subexpressions_of_explicitly_typed_fields.dart.direct.expect View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/subexpressions_of_explicitly_typed_fields.dart.outline.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/subexpressions_of_explicitly_typed_fields.dart.strong.expect View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_explicit_dynamic_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_explicit_type_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_constructor_call_no_type_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_no_type_param.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-25 19:57:19 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 20:05:31 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-25 20:22:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cefc4cc768b49f37b51ea8df2da87f4e8dcef9fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698