Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java

Issue 2905063002: Merge-59 [Payments] Fix metric log. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
index f6640797dfd471d87eba435884f10f5ddec16e59..bfdbf6546f177bd24bbcf3f8d99277f0c003b18a 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
@@ -135,16 +135,9 @@ public class PaymentRequestCanMakePaymentMetricsTest extends PaymentRequestTestB
// Initiate a payment request.
triggerUIAndWait("queryShow", mReadyForInput);
- // Press the back button.
- int callCount = mDismissed.getCallCount();
- ThreadUtils.runOnUiThreadBlocking(new Runnable() {
- @Override
- public void run() {
- mUI.getDialogForTest().onBackPressed();
- }
- });
- mDismissed.waitForCallback(callCount);
- expectResultContains(new String[] {"Request cancelled"});
+ // Simulate an abort by the merchant.
+ clickNodeAndWait("abort", mDismissed);
+ expectResultContains(new String[] {"Abort"});
// CanMakePayment was queried.
assertEquals(1,
@@ -164,7 +157,7 @@ public class PaymentRequestCanMakePaymentMetricsTest extends PaymentRequestTestB
assertEquals(1,
RecordHistogram.getHistogramValueCountForTesting(
"PaymentRequest.CanMakePayment.Used.TrueWithShowEffectOnCompletion",
- JourneyLogger.COMPLETION_STATUS_USER_ABORTED));
+ JourneyLogger.COMPLETION_STATUS_OTHER_ABORTED));
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698