Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2905013003: fix doc comments in dart:io and collection types (Closed)

Created:
3 years, 7 months ago by kevmoo
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, devoncarew, jcollins
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -42 lines) Patch
M sdk/lib/async/future.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/iterable.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/collection/maps.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/collection/queue.dart View 1 chunk +2 lines, -2 lines 1 comment Download
M sdk/lib/collection/set.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/core/iterable.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/data_transformer.dart View 1 chunk +6 lines, -12 lines 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/sync_socket.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kevmoo
In some cases I changed the argument name to match the doc comment from the ...
3 years, 7 months ago (2017-05-25 16:11:00 UTC) #2
kevmoo
CC devon, janice: the warnings in dartdoc are a great help here!
3 years, 7 months ago (2017-05-25 16:11:29 UTC) #3
Lasse Reichstein Nielsen
On 2017/05/25 16:11:00, kevmoo wrote: > In some cases I changed the argument name to ...
3 years, 6 months ago (2017-05-31 12:30:15 UTC) #4
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2905013003/diff/1/sdk/lib/collection/queue.dart File sdk/lib/collection/queue.dart (right): https://codereview.chromium.org/2905013003/diff/1/sdk/lib/collection/queue.dart#newcode560 sdk/lib/collection/queue.dart:560: void forEach(void f(E element)) { I'd actually prefer ...
3 years, 6 months ago (2017-05-31 12:30:22 UTC) #5
kevmoo
3 years, 6 months ago (2017-05-31 16:08:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46110c331b93338b52505d39bff7a6013e04e55f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698