Call IdleSpellCheckCallback::Deactivate() in PrepareForLeakDetection()

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1060 matching lines @@
 }
 
 DEFINE_TRACE(SpellChecker) {
   visitor->Trace(frame_);
   visitor->Trace(spell_check_requester_);
   visitor->Trace(idle_spell_check_callback_);
 }
 
 void SpellChecker::PrepareForLeakDetection() {
   spell_check_requester_->PrepareForLeakDetection();
+  idle_spell_check_callback_->Deactivate();

[Xiaocheng, 2017/05/26 21:15:09]

Please guard this line with

if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())

[hiroshige, 2017/05/26 21:40:03]

Done.

 }
 
 Vector<TextCheckingResult> SpellChecker::FindMisspellings(const String& text) {
   Vector<UChar> characters;
   text.AppendTo(characters);
   unsigned length = text.length();
 
   TextBreakIterator* iterator = WordBreakIterator(characters.data(), length);
   if (!iterator)
     return Vector<TextCheckingResult>();
@@ skipping 129 matching lines @@
       if (!input.IsFocusedElementInDocument())
         return false;
     }
   }
   HTMLElement* element =
       Traversal<HTMLElement>::FirstAncestorOrSelf(*position.AnchorNode());
   return element && element->IsSpellCheckingEnabled();
 }
 
 }  // namespace blink