Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2904963002: Remove unused <sys/syscall.h> inclusion on Fuchsia (Closed)

Created:
3 years, 7 months ago by kulakowski1
Modified:
3 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused <sys/syscall.h> inclusion on Fuchsia Fuchsia doesn't specify its syscall interface in this header. In fact, the header is empty, and we will soon remove it. So don't include it. R=zra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/58c0cacefbe69e7800ad230d5edf3ef0b65827f7

Patch Set 1 #

Total comments: 1

Patch Set 2 : correct host macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/cpu_arm64.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kulakowski1
3 years, 7 months ago (2017-05-24 19:26:35 UTC) #1
zra
https://codereview.chromium.org/2904963002/diff/1/runtime/vm/cpu_arm64.cc File runtime/vm/cpu_arm64.cc (right): https://codereview.chromium.org/2904963002/diff/1/runtime/vm/cpu_arm64.cc#newcode15 runtime/vm/cpu_arm64.cc:15: #if !defined(__Fuchsia__) #if !defined(HOST_OS_FUCHSIA)
3 years, 7 months ago (2017-05-24 19:30:39 UTC) #2
kulakowski1
On 2017/05/24 19:30:39, zra wrote: > https://codereview.chromium.org/2904963002/diff/1/runtime/vm/cpu_arm64.cc > File runtime/vm/cpu_arm64.cc (right): > > https://codereview.chromium.org/2904963002/diff/1/runtime/vm/cpu_arm64.cc#newcode15 > ...
3 years, 7 months ago (2017-05-24 19:32:43 UTC) #3
zra
lgtm
3 years, 7 months ago (2017-05-24 21:15:45 UTC) #4
zra
3 years, 7 months ago (2017-05-24 21:23:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
58c0cacefbe69e7800ad230d5edf3ef0b65827f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698