Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2904833002: LayoutObject::AbsoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)
Patch Set: RebasedAndUpdatedWithComments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index df0849ba475e947a4d79aa3ae87cb6e52fc76d45..54ee438acb1d0c9fc3c5fce1865acbba0a472cb0 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -994,13 +994,14 @@ IntRect LayoutObject::AbsoluteElementBoundingBoxRect() const {
.EnclosingBoundingBox();
}
-FloatRect LayoutObject::AbsoluteBoundingBoxRectForRange(const Range* range) {
- if (!range || !range->startContainer())
+FloatRect LayoutObject::AbsoluteBoundingBoxRectForRange(
+ const EphemeralRange& range) {
+ if (range.IsNull() || !range.StartPosition().ComputeContainerNode())
return FloatRect();
- range->OwnerDocument().UpdateStyleAndLayout();
+ range.GetDocument().UpdateStyleAndLayout();
- return ComputeTextFloatRect(EphemeralRange(range));
+ return ComputeTextFloatRect(range);
}
void LayoutObject::AddAbsoluteRectForLayer(IntRect& result) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698