Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 290483003: Tame the proliferation of UserContext constructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/managed_mode/chromeos/manager_password_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 34f5dbbebfadb78a411ef2a07382f691d5702262..3624e4028278f4a459a0d966d87ddfb9edbde56c 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -1144,14 +1144,12 @@ void SigninScreenHandler::HandleCompleteLogin(const std::string& typed_email,
const std::string sanitized_email = gaia::SanitizeEmail(typed_email);
delegate_->SetDisplayEmail(sanitized_email);
- delegate_->CompleteLogin(UserContext(
- sanitized_email,
- password,
- std::string(), // auth_code
- std::string(), // username_hash
- true, // using_oauth
- using_saml ? UserContext::AUTH_FLOW_GAIA_WITH_SAML
- : UserContext::AUTH_FLOW_GAIA_WITHOUT_SAML));
+ UserContext user_context(sanitized_email);
+ user_context.SetPassword(password);
+ user_context.SetAuthFlow(using_saml ?
+ UserContext::AUTH_FLOW_GAIA_WITH_SAML :
+ UserContext::AUTH_FLOW_GAIA_WITHOUT_SAML);
+ delegate_->CompleteLogin(user_context);
if (test_expects_complete_login_) {
VLOG(2) << "Complete test login for " << typed_email
@@ -1169,18 +1167,20 @@ void SigninScreenHandler::HandleCompleteAuthentication(
const std::string& auth_code) {
if (!delegate_)
return;
- const std::string sanitized_email = gaia::SanitizeEmail(email);
- delegate_->SetDisplayEmail(sanitized_email);
- delegate_->CompleteLogin(UserContext(sanitized_email, password, auth_code));
+ delegate_->SetDisplayEmail(gaia::SanitizeEmail(email));
+ UserContext user_context(email);
+ user_context.SetPassword(password);
+ user_context.SetAuthCode(auth_code);
+ delegate_->CompleteLogin(user_context);
}
void SigninScreenHandler::HandleAuthenticateUser(const std::string& username,
const std::string& password) {
if (!delegate_)
return;
- delegate_->Login(UserContext(gaia::SanitizeEmail(username),
- password,
- std::string())); // auth_code
+ UserContext user_context(username);
+ user_context.SetPassword(password);
+ delegate_->Login(user_context);
}
void SigninScreenHandler::HandleLaunchDemoUser() {
« no previous file with comments | « chrome/browser/managed_mode/chromeos/manager_password_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698