chrome/browser/chromeos/login/wizard_controller_browsertest.cc - Issue 290483003: Tame the proliferation of UserContext constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 290483003: Tame the proliferation of UserContext constructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

index 020f24dcaa3c2fd7baae95af23aa1dd99cf3bd0b..19eae189e78df804106c6a798843187e3b223e42 100644

--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

@@ -506,8 +506,9 @@ IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest,

&mock_consumer);

// This calls StartWizard, destroying the current controller() and its mocks;

// don't set expectations on those objects.

- ExistingUserController::current_controller()->CompleteLogin(

- UserContext(kUsername, kPassword, ""));

+ UserContext user_context(kUsername);

+ user_context.SetPassword(kPassword);

+ ExistingUserController::current_controller()->CompleteLogin(user_context);

// Run the tasks posted to complete the login:

base::MessageLoop::current()->RunUntilIdle();