chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc - Issue 290483003: Tame the proliferation of UserContext constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc

Issue 290483003: Tame the proliferation of UserContext constructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/login_utils_browsertest.cc ('k') | chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc

diff --git a/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc b/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc

index a6f3f3901f9a144ff6e8e3d9e0308a142b592c76..1dfbe9af963f9e88a7958d68a3dcf73ec72ba66f 100644

--- a/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc

+++ b/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc

@@ -202,10 +202,9 @@ void LocallyManagedUserCreationScreen::AuthenticateManager(

controller_.reset(new ManagedUserCreationControllerNew(this, manager_id));

}

- ExistingUserController::current_controller()->

- Login(UserContext(manager_id,

- manager_password,

- std::string() /* auth_code */));

+ UserContext user_context(manager_id);

+ user_context.SetPassword(manager_password);

+ ExistingUserController::current_controller()->Login(user_context);

}

void LocallyManagedUserCreationScreen::CreateManagedUser(