chrome/browser/chromeos/login/login_manager_test.cc - Issue 290483003: Tame the proliferation of UserContext constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_manager_test.cc

Issue 290483003: Tame the proliferation of UserContext constructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/login_manager_test.cc

diff --git a/chrome/browser/chromeos/login/login_manager_test.cc b/chrome/browser/chromeos/login/login_manager_test.cc

index 46c4bb6bd6578e08909d6df3e3decb8fb34f670d..9445f923136d27720c4b5d579ef08ad1e549edd0 100644

--- a/chrome/browser/chromeos/login/login_manager_test.cc

+++ b/chrome/browser/chromeos/login/login_manager_test.cc

@@ -81,7 +81,9 @@ bool LoginManagerTest::AddUserToSession(const std::string& username,

ADD_FAILURE();

return false;

}

- controller->Login(UserContext(username, password, std::string()));

+ UserContext user_context(username);

+ user_context.SetPassword(password);

+ controller->Login(user_context);

content::WindowedNotificationObserver(

chrome::NOTIFICATION_SESSION_STARTED,

content::NotificationService::AllSources()).Wait();