chrome/browser/chromeos/login/existing_user_controller.cc - Issue 290483003: Tame the proliferation of UserContext constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 290483003: Tame the proliferation of UserContext constructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/existing_user_controller.cc

diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc

index 474ccc13195b7aac6a2404e8ad45bfa28289da07..72e064b7459ef798ce87d6cc879430785177b4a7 100644

--- a/chrome/browser/chromeos/login/existing_user_controller.cc

+++ b/chrome/browser/chromeos/login/existing_user_controller.cc

@@ -422,10 +422,7 @@ void ExistingUserController::PerformLogin(

is_login_in_progress_ = true;

if (gaia::ExtractDomainName(user_context.GetUserID()) ==

UserManager::kLocallyManagedUserDomain) {

- login_performer_->LoginAsLocallyManagedUser(

- UserContext(user_context.GetUserID(),

- user_context.GetPassword(),

- std::string())); // auth_code

+ login_performer_->LoginAsLocallyManagedUser(user_context);

} else {

login_performer_->PerformLogin(user_context, auth_mode);

}