Tame the proliferation of UserContext constructors

chrome/browser/chromeos/login/users/user.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/user.h"
 
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_restrictions.h"
+#include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/users/avatar/default_user_images.h"
 #include "chrome/browser/chromeos/login/users/user_manager.h"
 #include "google_apis/gaia/gaia_auth_util.h"
+#include "google_apis/gaia/gaia_auth_util.h"
 #include "grit/theme_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace chromeos {
 
 namespace {
 
 // Returns account name portion of an email.
 std::string GetUserName(const std::string& email) {
   std::string::size_type i = email.find('@');
@@ skipping 76 matching lines @@
   explicit PublicAccountUser(const std::string& email);
   virtual ~PublicAccountUser();
 
   // Overridden from User:
   virtual UserType GetType() const OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PublicAccountUser);
 };
 
-UserContext::UserContext() : is_using_oauth_(true),
+UserContext::UserContext() : does_need_password_hashing_(true),
+                             is_using_oauth_(true),
                              auth_flow_(AUTH_FLOW_OFFLINE) {
 }
 
-UserContext::UserContext(const std::string& user_id,
-                         const std::string& password,
-                         const std::string& auth_code)
-    : user_id_(user_id),
-      password_(password),
+UserContext::UserContext(const UserContext& other)
+    : user_id_(other.user_id_),
+      password_(other.password_),
+      does_need_password_hashing_(other.does_need_password_hashing_),
+      key_label_(other.key_label_),
+      auth_code_(other.auth_code_),
+      user_id_hash_(other.user_id_hash_),
+      is_using_oauth_(other.is_using_oauth_),
+      auth_flow_(other.auth_flow_) {
+}
+
+UserContext::UserContext(const std::string& user_id)
+    : user_id_(login::CanonicalizeUserID(user_id)),
       does_need_password_hashing_(true),
-      auth_code_(auth_code),
       is_using_oauth_(true),
       auth_flow_(AUTH_FLOW_OFFLINE) {
 }
 
-UserContext::UserContext(const std::string& user_id,
-                         const std::string& password,
-                         const std::string& auth_code,
-                         const std::string& user_id_hash)
-    : user_id_(user_id),
-      password_(password),
-      does_need_password_hashing_(true),
-      auth_code_(auth_code),
-      user_id_hash_(user_id_hash),
-      is_using_oauth_(true),
-      auth_flow_(AUTH_FLOW_OFFLINE) {
-}
-
-UserContext::UserContext(const std::string& user_id,
-                         const std::string& password,
-                         const std::string& auth_code,
-                         const std::string& user_id_hash,
-                         bool is_using_oauth,
-                         AuthFlow auth_flow)
-    : user_id_(user_id),
-      password_(password),
-      does_need_password_hashing_(true),
-      auth_code_(auth_code),
-      user_id_hash_(user_id_hash),
-      is_using_oauth_(is_using_oauth),
-      auth_flow_(auth_flow) {
-}
-
 UserContext::~UserContext() {
 }
 
 bool UserContext::operator==(const UserContext& context) const {
   return context.user_id_ == user_id_ &&
          context.password_ == password_ &&
          context.does_need_password_hashing_ == does_need_password_hashing_ &&
          context.key_label_ == key_label_ &&
          context.auth_code_ == auth_code_ &&
          context.user_id_hash_ == user_id_hash_ &&
          context.is_using_oauth_ == is_using_oauth_ &&
          context.auth_flow_ == auth_flow_;
 }
 
-void UserContext::CopyFrom(const UserContext& other) {
-  user_id_ = other.user_id_;
-  password_ = other.password_;
-  does_need_password_hashing_ = other.does_need_password_hashing_;
-  key_label_ = other.key_label_;
-  auth_code_ = other.auth_code_;
-  user_id_hash_ = other.user_id_hash_;
-  is_using_oauth_ = other.is_using_oauth_;
-  auth_flow_ = other.auth_flow_;
-}
-
 const std::string& UserContext::GetUserID() const {
   return user_id_;
 }
 
 const std::string& UserContext::GetPassword() const {
   return password_;
 }
 
 bool UserContext::DoesNeedPasswordHashing() const {
   return does_need_password_hashing_;
@@ skipping 17 matching lines @@
 
 UserContext::AuthFlow UserContext::GetAuthFlow() const {
   return auth_flow_;
 }
 
 bool UserContext::HasCredentials() const {
   return (!user_id_.empty() && !password_.empty()) || !auth_code_.empty();
 }
 
 void UserContext::SetUserID(const std::string& user_id) {
-  user_id_ = user_id;
+  user_id_ = login::CanonicalizeUserID(user_id);
 }
 
 void UserContext::SetPassword(const std::string& password) {
   password_ = password;
 }
 
 void UserContext::SetDoesNeedPasswordHashing(bool does_need_password_hashing) {
   does_need_password_hashing_ = does_need_password_hashing;
 }
 
 void UserContext::SetKeyLabel(const std::string& key_label) {
   key_label_ = key_label;
 }
 
 void UserContext::SetAuthCode(const std::string& auth_code) {
   auth_code_ = auth_code;
 }
 
 void UserContext::SetUserIDHash(const std::string& user_id_hash) {
   user_id_hash_ = user_id_hash;
 }
 
 void UserContext::SetIsUsingOAuth(bool is_using_oauth) {
   is_using_oauth_ = is_using_oauth;
 }
 
+void UserContext::SetAuthFlow(AuthFlow auth_flow) {
+  auth_flow_ = auth_flow;
+}
+
+void UserContext::ClearSecrets() {
+  password_.clear();
+  auth_code_.clear();
+}
+
 std::string User::GetEmail() const {
   return display_email();
 }
 
 base::string16 User::GetDisplayName() const {
   // Fallback to the email account name in case display name haven't been set.
   return display_name_.empty() ?
       base::UTF8ToUTF16(GetAccountName(true)) :
       display_name_;
 }
@@ skipping 190 matching lines @@
     case USER_TYPE_LOCALLY_MANAGED:
     case USER_TYPE_KIOSK_APP:
       return false;
     default:
       NOTREACHED();
   }
   return false;
 }
 
 }  // namespace chromeos