chrome/app/theme/theme_resources.grd - Issue 2904823002: Inactive toast ux changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/theme/theme_resources.grd

Issue 2904823002: Inactive toast ux changes (Closed)

Patch Set: cleanup Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/theme/theme_resources.grd

diff --git a/chrome/app/theme/theme_resources.grd b/chrome/app/theme/theme_resources.grd

index 73174ca45a16b87ca1e676a3fff152c8d15b6489..04ce16fa5d6004964972a0a7793631378cc2b26b 100644

--- a/chrome/app/theme/theme_resources.grd

+++ b/chrome/app/theme/theme_resources.grd

@@ -214,6 +214,11 @@

</if>

+ <if expr="is_win">

+ <structure type="chrome_scaled_image" name="IDR_INACTIVE_TOAST_CARET" file="win/inactive_toast/toast_caret.png" />

+ <structure type="chrome_scaled_image" name="IDR_INACTIVE_TOAST_CLOSE_X" file="win/inactive_toast/toast_close.png" />

sky 2017/06/23 17:45:52 It isn't particularly clear what "CLOSE_X" means.

skare_ 2017/06/24 01:08:59 done - CLOSE_ICON

+ <structure type="chrome_scaled_image" name="IDR_INACTIVE_TOAST_ICON" file="win/inactive_toast/toast_icon.png" />

+ </if>