Allow setting breakpoints in literal function initializers of fields.

runtime/vm/debugger_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
 #include "vm/debugger.h"
 #include "vm/message.h"
 #include "vm/unit_test.h"
 
@@ skipping 53 matching lines @@
   result = Dart_SetBreakpoint(NewString("not_yet_loaded_script_uri"), 4);
   EXPECT_VALID(result);
   EXPECT(Dart_IsInteger(result));
   int64_t bp_id2 = 0;
   EXPECT_VALID(Dart_IntegerToInt64(result, &bp_id2));
 
   EXPECT(debugger->GetBreakpointById(bp_id1) != NULL);
   EXPECT(debugger->GetBreakpointById(bp_id2) != NULL);
 }
 
+TEST_CASE(Debugger_SetBreakpointInFunctionLiteralFieldInitializers) {
+  const char* kScriptChars =
+      "main() {\n"
+      "  var c = new MyClass();\n"
+      "  c.closure(1, 2);\n"
+      "  closure(3, 4);\n"
+      "}\n"
+      "class MyClass {\n"
+      "  var closure = (int a, int b) {\n"
+      "    return a + b;\n"
+      "  };\n"
+      "}\n"
+      "var closure = (int a, int b) {\n"
+      "  return a + b;\n"
+      "};\n";

[siva, 2017/05/24 19:51:23]

Can we add more tests
1. => function tests e.g var closure = (int a, int b) => a + b;
2. initialization with constant expressions to ensure we don't set breakpoints
there, e.g: var temp = 10; and try setting a breakpoint on that line, col
3. Not sure if tests already exists for static fields in a class with
initializers if not we should add those cases too.

[sivachandra, 2017/05/26 07:17:58]

Done.

+  SetFlagScope<bool> sfs(&FLAG_remove_script_timestamps_for_test, true);
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  EXPECT_VALID(lib);
+
+  Isolate* isolate = Isolate::Current();
+  Debugger* debugger = isolate->debugger();
+
+  Dart_Handle url = NewString(TestCase::url());
+  Dart_Handle result = Dart_SetBreakpoint(url, 8);
+  EXPECT_VALID(result);
+  EXPECT(Dart_IsInteger(result));
+  int64_t bp_id1 = 0;
+  EXPECT_VALID(Dart_IntegerToInt64(result, &bp_id1));
+
+  result = Dart_SetBreakpoint(url, 12);
+  EXPECT_VALID(result);
+  EXPECT(Dart_IsInteger(result));
+  int64_t bp_id2 = 0;
+  EXPECT_VALID(Dart_IntegerToInt64(result, &bp_id2));
+
+  EXPECT(debugger->GetBreakpointById(bp_id1) != NULL);
+  EXPECT(debugger->GetBreakpointById(bp_id2) != NULL);

[siva, 2017/05/24 19:51:23]

Should test if the breakpoint is actually hit by registering a
PausedEventHandler using Dart_SetPausedEventHandler(...) and checking in the
handler if the breakpoint is correct.

[sivachandra, 2017/05/26 07:17:58]

Done.

+}
+
 TEST_CASE(Debugger_RemoveBreakpoint) {
   const char* kScriptChars =
       "main() {\n"
       "  var x = new StringBuffer();\n"
       "  x.add('won');\n"
       "  x.add('too');\n"
       "  return x.toString();\n"
       "}\n";
   SetFlagScope<bool> sfs(&FLAG_remove_script_timestamps_for_test, true);
   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
@@ skipping 420 matching lines @@
       "enter(bar1) enter(bar2) enter(bar3) enter(foo) "
       "enter(bar3) enter(foo) "
       "exit(foo) exit(bar3) exit(bar2) exit(bar1) ",
       result_cstr);
   EXPECT(saw_paused_event);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart