Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 2904783002: Use failedAt in more places (misc) (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/invariant.dart ('k') | pkg/compiler/lib/src/library_loader.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/diagnostics/messages.dart
diff --git a/pkg/compiler/lib/src/diagnostics/messages.dart b/pkg/compiler/lib/src/diagnostics/messages.dart
index ae2e2b532705d45d04a5ca9cc40ff6320287e6cd..6424772cfe7aabfff580b8a65835ba917077deb6 100644
--- a/pkg/compiler/lib/src/diagnostics/messages.dart
+++ b/pkg/compiler/lib/src/diagnostics/messages.dart
@@ -16,7 +16,7 @@ library dart2js.messages;
import 'package:front_end/src/fasta/scanner.dart' show ErrorToken, Token;
import 'generated/shared_messages.dart' as shared_messages;
-import 'invariant.dart' show invariant;
+import 'invariant.dart' show failedAt;
import 'spannable.dart' show CURRENT_ELEMENT_SPANNABLE;
const DONT_KNOW_HOW_TO_FIX = "Computer says no!";
@@ -3762,11 +3762,11 @@ class Message {
arguments.forEach((key, value) {
message = message.replaceAll('#{${key}}', convertToString(value));
});
- assert(invariant(
- CURRENT_ELEMENT_SPANNABLE,
+ assert(
kind == MessageKind.GENERIC ||
!message.contains(new RegExp(r'#\{.+\}')),
- message: 'Missing arguments in error message: "$message"'));
+ failedAt(CURRENT_ELEMENT_SPANNABLE,
+ 'Missing arguments in error message: "$message"'));
if (!terse && template.hasHowToFix) {
String howToFix = template.howToFix;
arguments.forEach((key, value) {
« no previous file with comments | « pkg/compiler/lib/src/diagnostics/invariant.dart ('k') | pkg/compiler/lib/src/library_loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698