Use failedAt in more places (misc)

pkg/compiler/lib/src/compile_time_constants.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.compile_time_constant_evaluator;
 
 import 'common/resolution.dart' show Resolution;
 import 'common/tasks.dart' show CompilerTask, Measurer;
 import 'common.dart';
 import 'compiler.dart' show Compiler;
@@ skipping 183 matching lines @@
       VariableElement element, bool isConst, bool checkType) {
     if (initialVariableValues.containsKey(element.declaration)) {
       ConstantExpression result = initialVariableValues[element.declaration];
       return result;
     }
     if (element.hasConstant) {
       if (element.constant != null) {
         if (compiler.serialization.supportsDeserialization) {
           evaluate(element.constant);
         }
-        assert(invariant(element, hasConstantValue(element.constant),
-            message: "Constant expression has not been evaluated: "
+        assert(
+            hasConstantValue(element.constant),
+            failedAt(
+                element,
+                "Constant expression has not been evaluated: "
                 "${element.constant.toStructuredText()}."));
       }
       return element.constant;
     }
     AstElement currentElement = element.analyzableElement;
     return reporter.withCurrentElement(element, () {
       // TODO(johnniwinther): Avoid this eager analysis.
       compiler.resolution.ensureResolved(currentElement.declaration);
 
       ConstantExpression constant = compileVariableWithDefinitions(
@@ skipping 70 matching lines @@
               expression = null;
             }
           }
         }
       }
     }
     if (expression != null) {
       element.constant = expression;
       initialVariableValues[element.declaration] = expression;
     } else {
-      assert(invariant(element, !isConst,
-          message: "Variable $element does not compile to a constant."));
+      assert(
+          !isConst,
+          failedAt(
+              element, "Variable $element does not compile to a constant."));
     }
     pendingVariables.remove(element);
     return expression;
   }
 
   void cacheConstantValue(ConstantExpression expression, ConstantValue value) {
     constantValueMap[expression] = value;
   }
 
   ConstantExpression compileNodeWithDefinitions(
@@ skipping 10 matching lines @@
     }
     return null;
   }
 
   bool hasConstantValue(ConstantExpression expression) {
     return constantValueMap.containsKey(expression);
   }
 
   @override
   ConstantValue getConstantValue(ConstantExpression expression) {
-    assert(invariant(CURRENT_ELEMENT_SPANNABLE, expression != null,
-        message: "ConstantExpression is null in getConstantValue."));
+    assert(
+        expression != null,
+        failedAt(CURRENT_ELEMENT_SPANNABLE,
+            "ConstantExpression is null in getConstantValue."));
     // TODO(johnniwinther): ensure expressions have been evaluated at this
     // point. This can't be enabled today due to dartbug.com/26406.
     if (compiler.serialization.supportsDeserialization) {
       evaluate(expression);
     }
     ConstantValue value = constantValueMap[expression];
     if (value == null &&
         expression != null &&
         expression.kind == ConstantExpressionKind.ERRONEOUS) {
       // TODO(johnniwinther): When the Dart constant system sees a constant
@@ skipping 59 matching lines @@
 
   ConstantSystem get constantSystem => handler.constantSystem;
   Resolution get resolution => compiler.resolution;
   CommonElements get commonElements => compiler.commonElements;
   DiagnosticReporter get reporter => compiler.reporter;
 
   AstConstant evaluate(Node node) {
     // TODO(johnniwinther): should there be a visitErrorNode?
     if (node is ErrorNode) return new ErroneousAstConstant(context, node);
     AstConstant result = node.accept(this);
-    assert(invariant(node, !isEvaluatingConstant || result != null,
-        message: "No AstConstant computed for the node."));
+    assert(!isEvaluatingConstant || result != null,
+        failedAt(node, "No AstConstant computed for the node."));
     return result;
   }
 
   AstConstant evaluateConstant(Node node) {
     bool oldIsEvaluatingConstant = isEvaluatingConstant;
     isEvaluatingConstant = true;
     AstConstant result = node.accept(this);
     isEvaluatingConstant = oldIsEvaluatingConstant;
-    assert(invariant(node, result != null,
-        message: "No AstConstant computed for the node."));
+    assert(result != null,
+        failedAt(node, "No AstConstant computed for the node."));
     return result;
   }
 
   AstConstant visitNode(Node node) {
     return signalNotCompileTimeConstant(node);
   }
 
   AstConstant visitLiteralBool(LiteralBool node) {
     return new AstConstant(
         context,
@@ skipping 406 matching lines @@
    * omitted optional arguments.
    *
    * Invariant: [target] must be an implementation element.
    */
   List<AstConstant> evaluateArgumentsToConstructor(
       Node node,
       CallStructure callStructure,
       Link<Node> arguments,
       ConstructorElement target,
       {AstConstant compileArgument(Node node)}) {
-    assert(invariant(node, target.isImplementation));
+    assert(target.isImplementation, failedAt(node));
 
     AstConstant compileDefaultValue(VariableElement element) {
       ConstantExpression constant = handler.compileConstant(element);
       return new AstConstant.fromDefaultValue(
           element, constant, handler.getConstantValue(constant));
     }
 
     target.computeType(resolution);
 
     if (!callStructure.signatureApplies(target.parameterStructure)) {
@@ skipping 228 matching lines @@
       Node node,
       ResolutionInterfaceType type,
       ConstructorElement constructor,
       ResolutionInterfaceType constructedType,
       ConstructorElement target,
       CallStructure callStructure,
       List<AstConstant> concreteArguments,
       List<AstConstant> normalizedArguments) {
     if (target.isRedirectingFactory) {
       // This happens in case of cyclic redirection.
-      assert(invariant(node, compiler.compilationFailed,
-          message: "makeConstructedConstant can only be called with the "
+      assert(
+          compiler.compilationFailed,
+          failedAt(
+              node,
+              "makeConstructedConstant can only be called with the "
               "effective target: $constructor"));
       return new ErroneousAstConstant(context, node);
     }
-    assert(invariant(
-        node,
+    assert(
         callStructure.signatureApplies(constructor.parameterStructure) ||
             compiler.compilationFailed,
-        message: "Call structure $callStructure does not apply to constructor "
+        failedAt(
+            node,
+            "Call structure $callStructure does not apply to constructor "
             "$constructor."));
 
     ConstructorEvaluator evaluator =
         new ConstructorEvaluator(constructedType, target, handler, compiler);
     evaluator.evaluateConstructorFieldValues(normalizedArguments);
     Map<FieldElement, AstConstant> fieldConstants =
         evaluator.buildFieldConstants(target.enclosingClass);
     Map<FieldElement, ConstantValue> fieldValues =
         <FieldElement, ConstantValue>{};
     fieldConstants.forEach((FieldElement field, AstConstant astConstant) {
@@ skipping 54 matching lines @@
       ResolutionInterfaceType this.constructedType,
       ConstructorElement constructor,
       ConstantCompiler handler,
       Compiler compiler)
       : this.constructor = constructor,
         this.definitions = new Map<Element, AstConstant>(),
         this.fieldValues = new Map<Element, AstConstant>(),
         this.resolvedAst =
             compiler.resolution.computeResolvedAst(constructor.declaration),
         super(handler, null, compiler, isConst: true) {
-    assert(invariant(constructor, constructor.isImplementation));
+    assert(constructor.isImplementation, failedAt(constructor));
   }
 
   @override
   Element get context => resolvedAst.element;
 
   @override
   TreeElements get elements => resolvedAst.elements;
 
   AstConstant visitSend(Send send) {
     Element element = elements[send];
@@ skipping 269 matching lines @@
   @override
   ConstantExpression getFieldConstant(FieldElement field) {
     return field.constant;
   }
 
   @override
   ConstantExpression getLocalConstant(LocalVariableElement local) {
     return local.constant;
   }
 }