Issue 2904773003: Add _Dart_IsReloading to framework.order for MacOS.

Issue 2904773003: Add _Dart_IsReloading to framework.order for MacOS. (Closed)

Created:
3 years, 7 months ago by Bill Hesse

Modified:
3 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), terry, kustermann

CC:
reviews+dom_dartlang.org

Target Ref:
refs/heads/releases/2661_work

Visibility:
Public.

More Reviews

Description

Add _Dart_IsReloading to framework.order for MacOS. BUG= R=kustermann@google.com Committed: https://src.chromium.org/viewvc/chrome/branches/dart/dartium/src?view=rev&revision=a0717ebdcf4578b98de1d858005aa9c5f346bd33

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	OWNERS	View		1 chunk	+7 lines, -10 lines	0 comments	Download
	M	chrome/app/framework.order	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

Committed patchset #1 (id:1) manually as a0717ebdcf4578b98de1d858005aa9c5f346bd33.

3 years, 7 months ago (2017-05-24 09:09:46 UTC) #5

terry

Bill any idea why we've been able to change src with the incorrect OWNERS file?

3 years, 7 months ago (2017-05-24 13:38:50 UTC) #7

Bill Hesse

3 years, 7 months ago (2017-05-24 13:40:08 UTC) #8

Message was sent while issue was closed.

On 2017/05/24 13:38:50, terry wrote:
> Bill any idea why we've been able to change src with the incorrect OWNERS
file?

OWNERS seems to only affect the presubmit of git cl upload or git cl land, so
using --bypass-hooks on land allows us to land.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages