cc: Add UMA for tracking decode duration for out of raster decodes.

cc/base/devtools_instrumentation.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_BASE_DEVTOOLS_INSTRUMENTATION_H_
 #define CC_BASE_DEVTOOLS_INSTRUMENTATION_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 39 matching lines @@
   ~ScopedLayerTask() { TRACE_EVENT_END0(internal::kCategory, event_name_); }
 
  private:
   const char* event_name_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedLayerTask);
 };
 
 class CC_BASE_EXPORT ScopedImageDecodeTask {
  public:
   enum Type { SOFTWARE, GPU };

[vmpstr, 2017/05/30 20:15:12]

Can you change this to be consistent with the naming, please.

Can you also change the enum name to be DecodeType and DecodeTaskType to be
TaskType

[Khushal, 2017/05/31 18:21:20]

Done.

+  enum DecodeTaskType { kInRaster, kCheckerImaging, kJSDecode };
 
-  ScopedImageDecodeTask(const void* imagePtr, Type type)
-      : type_(type), start_time_(base::TimeTicks::Now()) {
+  ScopedImageDecodeTask(const void* imagePtr,

[vmpstr, 2017/05/30 20:15:12]

image_ptr while here

[Khushal, 2017/05/31 18:21:20]

Done.

+                        Type type,
+                        DecodeTaskType task_type)
+      : type_(type),
+        task_type_(task_type),
+        start_time_(base::TimeTicks::Now()) {
     TRACE_EVENT_BEGIN1(internal::kCategory, internal::kImageDecodeTask,
                        internal::kPixelRefId,
                        reinterpret_cast<uint64_t>(imagePtr));
   }
   ~ScopedImageDecodeTask() {
     TRACE_EVENT_END0(internal::kCategory, internal::kImageDecodeTask);
     base::TimeDelta duration = base::TimeTicks::Now() - start_time_;
-    switch (type_) {
-      case SOFTWARE:
-        UMA_HISTOGRAM_COUNTS_1M("Renderer4.ImageDecodeTaskDurationUs.Software",
-                                duration.InMicroseconds());
+    switch (task_type_) {
+      case kInRaster:
+        switch (type_) {
+          case SOFTWARE:
+            UMA_HISTOGRAM_COUNTS_1M(
+                "Renderer4.ImageDecodeTaskDurationUs.Software",
+                duration.InMicroseconds());
+            break;
+          case GPU:
+            UMA_HISTOGRAM_COUNTS_1M("Renderer4.ImageDecodeTaskDurationUs.Gpu",
+                                    duration.InMicroseconds());
+            break;
+        }
         break;
-      case GPU:
-        UMA_HISTOGRAM_COUNTS_1M("Renderer4.ImageDecodeTaskDurationUs.Gpu",
-                                duration.InMicroseconds());
+      case kCheckerImaging:
+        switch (type_) {
+          case SOFTWARE:
+            UMA_HISTOGRAM_COUNTS_1M(
+                "Renderer4.ImageDecodeTaskDurationUs.CheckerImaging.Software",
+                duration.InMicroseconds());
+            break;
+          case GPU:
+            UMA_HISTOGRAM_COUNTS_1M(
+                "Renderer4.ImageDecodeTaskDurationUs.CheckerImaging.Gpu",
+                duration.InMicroseconds());
+            break;
+        }
+        break;
+      case kJSDecode:
+        switch (type_) {
+          case SOFTWARE:
+            UMA_HISTOGRAM_COUNTS_1M(
+                "Renderer4.ImageDecodeTaskDurationUs.JSDecode.Software",
+                duration.InMicroseconds());
+            break;
+          case GPU:
+            UMA_HISTOGRAM_COUNTS_1M(
+                "Renderer4.ImageDecodeTaskDurationUs.JSDecode.Gpu",
+                duration.InMicroseconds());
+            break;
+        }
         break;
     }
   }
 
  private:
   const Type type_;
+  const DecodeTaskType task_type_;
   const base::TimeTicks start_time_;
   DISALLOW_COPY_AND_ASSIGN(ScopedImageDecodeTask);
 };
 
 class CC_BASE_EXPORT ScopedLayerTreeTask {
  public:
   ScopedLayerTreeTask(const char* event_name,
                       int layer_id,
                       int layer_tree_host_id)
       : event_name_(event_name) {
@@ skipping 87 matching lines @@
   TRACE_EVENT_INSTANT2(
       internal::kCategoryFrame, internal::kNeedsBeginFrameChanged,
       TRACE_EVENT_SCOPE_THREAD, internal::kLayerTreeId, layer_tree_host_id,
       internal::kData, NeedsBeginFrameData(new_value));
 }
 
 }  // namespace devtools_instrumentation
 }  // namespace cc
 
 #endif  // CC_BASE_DEVTOOLS_INSTRUMENTATION_H_