Add a TouchEventStreamValidator

content/browser/renderer_host/input/input_router_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <math.h>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 224 matching lines @@
   void SimulateGestureFlingStartEvent(
       float velocityX,
       float velocityY,
       WebGestureEvent::SourceDevice sourceDevice) {
     SimulateGestureEvent(
         SyntheticWebGestureEventBuilder::BuildFling(velocityX,
                                                     velocityY,
                                                     sourceDevice));
   }
 
-  void SimulateTouchEvent(WebInputEvent::Type type) {
-    touch_event_.ResetPoints();
-    int index = PressTouchPoint(0, 0);
-    switch (type) {
-      case WebInputEvent::TouchStart:
-        // Already handled by |PressTouchPoint()|.
-        break;
-      case WebInputEvent::TouchMove:
-        MoveTouchPoint(index, 5, 5);
-        break;
-      case WebInputEvent::TouchEnd:
-        ReleaseTouchPoint(index);
-        break;
-      case WebInputEvent::TouchCancel:
-        CancelTouchPoint(index);
-        break;
-      default:
-        FAIL() << "Invalid touch event type.";
-        break;
-    }
-    SendTouchEvent();
-  }
-
   void SetTouchTimestamp(base::TimeDelta timestamp) {
     touch_event_.SetTimestamp(timestamp);
   }
 
   void SendTouchEvent() {
     input_router_->SendTouchEvent(
         TouchEventWithLatencyInfo(touch_event_, ui::LatencyInfo()));
     touch_event_.ResetPoints();
   }
 
@@ skipping 501 matching lines @@
   EXPECT_TRUE(process_->sink().GetUniqueMessageMatching(
                   InputMsg_HandleInputEvent::ID));
   EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
 
   // Check that the correct unhandled wheel event was received.
   EXPECT_EQ(ack_handler_->acked_wheel_event().deltaY, -5);
 }
 
 TEST_F(InputRouterImplTest, TouchTypesIgnoringAck) {
   OnHasTouchEventHandlers(true);
+  // Only acks for TouchCancel should always be ignored.
+  ASSERT_FALSE(WebInputEventTraits::IgnoresAckDisposition(
+      GetEventWithType(WebInputEvent::TouchStart)));
+  ASSERT_FALSE(WebInputEventTraits::IgnoresAckDisposition(
+      GetEventWithType(WebInputEvent::TouchMove)));
+  ASSERT_FALSE(WebInputEventTraits::IgnoresAckDisposition(
+      GetEventWithType(WebInputEvent::TouchEnd)));
 
-  int start_type = static_cast<int>(WebInputEvent::TouchStart);
-  int end_type = static_cast<int>(WebInputEvent::TouchCancel);
-  ASSERT_LT(start_type, end_type);
-  for (int i = start_type; i <= end_type; ++i) {
-    WebInputEvent::Type type = static_cast<WebInputEvent::Type>(i);
-    if (!WebInputEventTraits::IgnoresAckDisposition(GetEventWithType(type)))
-      continue;
+  // Precede the TouchCancel with an appropriate TouchStart;
+  PressTouchPoint(1, 1);
+  SendTouchEvent();
+  SendInputEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED);
+  ASSERT_EQ(1U, GetSentMessageCountAndResetSink());
+  ASSERT_EQ(1U, ack_handler_->GetAndResetAckCount());
+  ASSERT_EQ(0, client_->in_flight_event_count());
 
-    // The TouchEventQueue requires an initial TouchStart for it to begin
-    // forwarding other touch event types.
-    if (type != WebInputEvent::TouchStart) {
-      SimulateTouchEvent(WebInputEvent::TouchStart);
-      SendInputEventACK(WebInputEvent::TouchStart,
-                        INPUT_EVENT_ACK_STATE_CONSUMED);
-      ASSERT_EQ(1U, GetSentMessageCountAndResetSink());
-      ASSERT_EQ(1U, ack_handler_->GetAndResetAckCount());
-      ASSERT_EQ(0, client_->in_flight_event_count());
-    }
-
-    SimulateTouchEvent(type);
-    EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
-    EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount());
-    EXPECT_EQ(0, client_->in_flight_event_count());
-    EXPECT_FALSE(HasPendingEvents());
-    SendInputEventACK(type, INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
-    EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
-    EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount());
-    EXPECT_FALSE(HasPendingEvents());
-  }
+  // The TouchCancel ack is always ignored.
+  CancelTouchPoint(0);
+  SendTouchEvent();
+  EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
+  EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount());
+  EXPECT_EQ(0, client_->in_flight_event_count());
+  EXPECT_FALSE(HasPendingEvents());
+  SendInputEventACK(WebInputEvent::TouchCancel,
+                    INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
+  EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
+  EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount());
+  EXPECT_FALSE(HasPendingEvents());
 }
 
 TEST_F(InputRouterImplTest, GestureTypesIgnoringAck) {
   // We test every gesture type, ensuring that the stream of gestures is valid.
   const int kEventTypesLength = 29;
   WebInputEvent::Type eventTypes[kEventTypesLength] = {
       WebInputEvent::GestureTapDown,
       WebInputEvent::GestureShowPress,
       WebInputEvent::GestureTapCancel,
       WebInputEvent::GestureScrollBegin,
@@ skipping 905 matching lines @@
   client_overscroll = client_->GetAndResetOverscroll();
   EXPECT_EQ(wheel_overscroll.accumulated_overscroll,
             client_overscroll.accumulated_overscroll);
   EXPECT_EQ(wheel_overscroll.latest_overscroll_delta,
             client_overscroll.latest_overscroll_delta);
   EXPECT_EQ(wheel_overscroll.current_fling_velocity,
             client_overscroll.current_fling_velocity);
 }
 
 }  // namespace content