Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3967)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

Issue 2904713002: [Home] Wait to monitor NTP content suggestions until new tab created (Closed)
Patch Set: Revert changes to SuggestionsBottomSheetContent Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
index e524109a7dabe5792a10dec0085ad6ce3ce3d6f6..2b3aa24e235b6366c182f2d020070bb87ec16ce2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
@@ -108,11 +108,6 @@ public class SuggestionsNavigationDelegateImpl implements SuggestionsNavigationD
return;
}
- // TODO(treib): Also track other dispositions. crbug.com/665915
- if (windowOpenDisposition == WindowOpenDisposition.CURRENT_TAB) {
- NewTabPageUma.monitorContentSuggestionVisit(mHost.getActiveTab(), article.mCategory);
- }
-
LoadUrlParams loadUrlParams;
// We explicitly open an offline page only for offline page downloads. For all other
// sections the URL is opened and it is up to Offline Pages whether to open its offline
@@ -139,6 +134,11 @@ public class SuggestionsNavigationDelegateImpl implements SuggestionsNavigationD
}
openUrl(windowOpenDisposition, loadUrlParams);
+
+ // TODO(treib): Also track other dispositions. crbug.com/665915
+ if (windowOpenDisposition == WindowOpenDisposition.CURRENT_TAB) {
+ NewTabPageUma.monitorContentSuggestionVisit(mHost.getActiveTab(), article.mCategory);
+ }
}
@Override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698