Remove AstFactory from the front end.

Remove AstFactory from the front end.

R=ahe@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a21b9e56387ee0413fe2f3ddcb2dbe5229cee07f

[Paul Berry, 2017-05-24 18:03:04]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-05-24 18:07:17]

LGTM

[ahe, 2017-05-24 18:12:58]

LGTM!

It's nice to see how you add more offsets.

A few thoughts for future CLs:

Would it make sense to change the prefix from Kernel to Fasta?

I personally think it would be nice have offsets be mandatory arguments on all
the shadow hierarchy constructors.

https://codereview.chromium.org/2904673003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2904673003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:14: import
'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
FWIW, I think it makes sense to remove the show clause on this import. I know
it's very subjective, so it's up to you.

[Paul Berry, 2017-05-24 18:24:11]

https://codereview.chromium.org/2904673003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2904673003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:14: import
'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
On 2017/05/24 18:12:57, ahe wrote:
> FWIW, I think it makes sense to remove the show clause on this import. I know
> it's very subjective, so it's up to you.

Agreed, it's not adding much value at this point :)

Done.

[Paul Berry, 2017-05-24 18:24:46]

On 2017/05/24 18:12:58, ahe wrote:
> LGTM!
> 
> It's nice to see how you add more offsets.
> 
> A few thoughts for future CLs:
> 
> Would it make sense to change the prefix from Kernel to Fasta?
> 
> I personally think it would be nice have offsets be mandatory arguments on all
> the shadow hierarchy constructors.

I think those are both good ideas, thanks.  I'll add them to my TODO list.

[Paul Berry, 2017-05-24 18:28:15]

Description was changed from

==========
Remove AstFactory from the front end.
==========

to

==========
Remove AstFactory from the front end.

R=ahe@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a21b9e56387ee0413fe2f3ddcb2dbe5229cee07f
==========

[Paul Berry, 2017-05-24 18:28:17]

Committed patchset #1 (id:1) manually as
a21b9e56387ee0413fe2f3ddcb2dbe5229cee07f (presubmit successful).