Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2904653002: Always record inference of implicit function expression params, even if dynamic. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Always record inference of implicit function expression params, even if dynamic. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a3e11d2e6e634cf61180536eb834acb2bd51517b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-23 18:58:02 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-23 19:00:16 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-23 19:32:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3e11d2e6e634cf61180536eb834acb2bd51517b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698