Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: net/http/http_stream_factory_impl_request_unittest.cc

Issue 2904643002: Remove some naked |new| statements in favor of MakeUnique. (Closed)
Patch Set: Revert changes in one test where it caused a crash. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_stream_factory_impl_request.h" 5 #include "net/http/http_stream_factory_impl_request.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility>
8 9
9 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
10 #include "base/run_loop.h" 11 #include "base/run_loop.h"
11 #include "net/http/http_stream_factory_impl.h" 12 #include "net/http/http_stream_factory_impl.h"
12 #include "net/http/http_stream_factory_impl_job.h" 13 #include "net/http/http_stream_factory_impl_job.h"
13 #include "net/http/http_stream_factory_impl_job_controller.h" 14 #include "net/http/http_stream_factory_impl_job_controller.h"
14 #include "net/http/http_stream_factory_test_util.h" 15 #include "net/http/http_stream_factory_test_util.h"
15 #include "net/proxy/proxy_info.h" 16 #include "net/proxy/proxy_info.h"
16 #include "net/proxy/proxy_service.h" 17 #include "net/proxy/proxy_service.h"
17 #include "net/spdy/chromium/spdy_test_util_common.h" 18 #include "net/spdy/chromium/spdy_test_util_common.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 EXPECT_EQ(MEDIUM, job_controller_raw_ptr->main_job()->priority()); 55 EXPECT_EQ(MEDIUM, job_controller_raw_ptr->main_job()->priority());
55 56
56 EXPECT_CALL(request_delegate, OnStreamFailed(_, _)).Times(1); 57 EXPECT_CALL(request_delegate, OnStreamFailed(_, _)).Times(1);
57 job_controller_raw_ptr->OnStreamFailed(job_factory.main_job(), ERR_FAILED, 58 job_controller_raw_ptr->OnStreamFailed(job_factory.main_job(), ERR_FAILED,
58 SSLConfig()); 59 SSLConfig());
59 60
60 request->SetPriority(IDLE); 61 request->SetPriority(IDLE);
61 EXPECT_EQ(IDLE, job_controller_raw_ptr->main_job()->priority()); 62 EXPECT_EQ(IDLE, job_controller_raw_ptr->main_job()->priority());
62 } 63 }
63 } // namespace net 64 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698