Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: net/ntlm/ntlm_constants.h

Issue 2904633002: Replace NTLMv1 implementation with a functionally equivalent one.
Patch Set: Fix uninitialized read Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ntlm/ntlm_client_unittest.cc ('k') | net/ntlm/ntlm_test_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ntlm/ntlm_constants.h
diff --git a/net/ntlm/ntlm_constants.h b/net/ntlm/ntlm_constants.h
index 53f69a64bd309a9165b3796dcfb2f8eeb38f4171..cebba53b8f35dcc61d617039469edc2afe214865 100644
--- a/net/ntlm/ntlm_constants.h
+++ b/net/ntlm/ntlm_constants.h
@@ -38,7 +38,7 @@ enum class NtlmVersion {
};
// There are 3 types of messages in NTLM. The message type is a field in
-// every NTLM message header.
+// every NTLM message header. See [MS-NLMP] Section 2.2.
enum class MessageType : uint32_t {
kNegotiate = 0x01,
kChallenge = 0x02,
@@ -78,10 +78,15 @@ static constexpr size_t kSignatureLen = arraysize(kSignature);
static constexpr size_t kSecurityBufferLen =
(2 * sizeof(uint16_t)) + sizeof(uint32_t);
static constexpr size_t kNegotiateMessageLen = 32;
+static constexpr size_t kMinChallengeHeaderLen = 32;
static constexpr size_t kChallengeHeaderLen = 32;
static constexpr size_t kResponseLenV1 = 24;
static constexpr size_t kChallengeLen = 8;
static constexpr size_t kNtlmHashLen = 16;
+static constexpr size_t kAuthenticateHeaderLenV1 = 64;
+static constexpr size_t kMaxFqdnLen = 255;
+static constexpr size_t kMaxUsernameLen = 104;
+static constexpr size_t kMaxPasswordLen = 256;
static constexpr NegotiateFlags kNegotiateMessageFlags =
NegotiateFlags::kUnicode | NegotiateFlags::kOem |
« no previous file with comments | « net/ntlm/ntlm_client_unittest.cc ('k') | net/ntlm/ntlm_test_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698