Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: net/http/http_auth_handler_ntlm.h

Issue 2904633002: Replace NTLMv1 implementation with a functionally equivalent one.
Patch Set: Only return malloc memory from NtlmClient Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_handler_ntlm.h
diff --git a/net/http/http_auth_handler_ntlm.h b/net/http/http_auth_handler_ntlm.h
index fed6303f834f0d1e7980a18afe10900691b14569..4d4b73ef00cec9cadbe9c5ecab76e33a94718660 100644
--- a/net/http/http_auth_handler_ntlm.h
+++ b/net/http/http_auth_handler_ntlm.h
@@ -23,6 +23,8 @@
#include <windows.h>
#include <security.h>
#include "net/http/http_auth_sspi_win.h"
+#elif defined(NTLM_PORTABLE)
+#include "net/ntlm/ntlm_client.h"
#endif
#include <string>
@@ -70,6 +72,8 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerNTLM : public HttpAuthHandler {
};
#if defined(NTLM_PORTABLE)
+ static void GenerateRandom(uint8_t* output, size_t n);
asanka 2017/07/14 16:52:38 This doesn't need to be a part of HttpAuthHandlerN
zentaro 2017/07/19 15:20:12 Done.
+
// A function that generates n random bytes in the output buffer.
typedef void (*GenerateRandomProc)(uint8_t* output, size_t n);
@@ -152,6 +156,8 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerNTLM : public HttpAuthHandler {
#if defined(NTLM_SSPI)
HttpAuthSSPI auth_sspi_;
+#elif defined(NTLM_PORTABLE)
+ ntlm::NtlmClient ntlm_client_;
#endif
#if defined(NTLM_PORTABLE)
« no previous file with comments | « net/BUILD.gn ('k') | net/http/http_auth_handler_ntlm_portable.cc » ('j') | net/ntlm/ntlm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698