Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: net/ntlm/ntlm_constants.h

Issue 2904633002: Replace NTLMv1 implementation with a functionally equivalent one.
Patch Set: Merge build config back to net Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ntlm/ntlm_constants.h
diff --git a/net/ntlm/ntlm_constants.h b/net/ntlm/ntlm_constants.h
index cdfb71a80218690b5c4e3e8503f4d7e8ecb676bf..f3cce23905e8f3ec61cf874a7aab0fc05b904313 100644
--- a/net/ntlm/ntlm_constants.h
+++ b/net/ntlm/ntlm_constants.h
@@ -35,7 +35,7 @@ enum class NtlmVersion {
};
// There are 3 types of messages in NTLM. The message type is a field in
-// every NTLM message header.
+// every NTLM message header. See [MS-NLMP] Section 2.2.
enum class MessageType : uint32_t {
NEGOTIATE = 0x01,
CHALLENGE = 0x02,
@@ -75,10 +75,12 @@ static constexpr size_t SIGNATURE_LEN = arraysize(SIGNATURE);
static constexpr size_t SECURITY_BUFFER_LEN =
(2 * sizeof(uint16_t)) + sizeof(uint32_t);
static constexpr size_t NEGOTIATE_MESSAGE_LEN = 32;
+static constexpr size_t MIN_CHALLENGE_HEADER_LEN = 32;
static constexpr size_t CHALLENGE_HEADER_LEN = 32;
static constexpr size_t RESPONSE_V1_LEN = 24;
static constexpr size_t CHALLENGE_LEN = 8;
static constexpr size_t NTLM_HASH_LEN = 16;
+static constexpr size_t AUTHENTICATE_HEADER_V1_LEN = 64;
static constexpr NegotiateFlags NEGOTIATE_MESSAGE_FLAGS =
NegotiateFlags::UNICODE | NegotiateFlags::OEM |

Powered by Google App Engine
This is Rietveld 408576698