Disable permissions dialog in VR

chrome/browser/permissions/permission_manager_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_manager.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/permissions/permission_manager_factory.h"
 #include "chrome/browser/permissions/permission_result.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "content/public/browser/permission_type.h"
 #include "content/public/test/test_browser_thread_bundle.h"
+#include "content/public/test/test_renderer_host.h"
+#include "device/vr/features/features.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if BUILDFLAG(ENABLE_VR)
+#include "chrome/browser/android/vr_shell/vr_tab_helper.h"
+#endif  // BUILDFLAG(ENABLE_VR)
+
 using blink::mojom::PermissionStatus;
 using content::PermissionType;
 
 namespace {
 
+int kNoPendingOperation = -1;
+
 class PermissionManagerTestingProfile final : public TestingProfile {
  public:
   PermissionManagerTestingProfile() {}
   ~PermissionManagerTestingProfile() override {}
 
   PermissionManager* GetPermissionManager() override {
     return PermissionManagerFactory::GetForProfile(this);
   }
 
   DISALLOW_COPY_AND_ASSIGN(PermissionManagerTestingProfile);
 };
 
 }  // anonymous namespace
 
-class PermissionManagerTest : public testing::Test {
+class PermissionManagerTest : public content::RenderViewHostTestHarness {
  public:
   void OnPermissionChange(PermissionStatus permission) {
     callback_called_ = true;
     callback_result_ = permission;
   }
 
  protected:
   PermissionManagerTest()
       : url_("https://example.com"),
         other_url_("https://foo.com"),
@@ skipping 47 matching lines @@
     callback_result_ = PermissionStatus::ASK;
   }
 
  private:
   const GURL url_;
   const GURL other_url_;
   bool callback_called_;
   PermissionStatus callback_result_;
   content::TestBrowserThreadBundle thread_bundle_;
   PermissionManagerTestingProfile profile_;
+  void SetUp() override { RenderViewHostTestHarness::SetUp(); }
+
+  void TearDown() override { RenderViewHostTestHarness::TearDown(); }

[raymes, 2017/05/30 00:32:32]

nit: methods always go above member variables

[asimjour1, 2017/05/30 18:27:45]

Done.

 };
 
 TEST_F(PermissionManagerTest, GetPermissionStatusDefault) {
   CheckPermissionStatus(PermissionType::MIDI_SYSEX, PermissionStatus::ASK);
   CheckPermissionStatus(PermissionType::PUSH_MESSAGING, PermissionStatus::ASK);
   CheckPermissionStatus(PermissionType::NOTIFICATIONS, PermissionStatus::ASK);
   CheckPermissionStatus(PermissionType::GEOLOCATION, PermissionStatus::ASK);
 #if defined(OS_ANDROID)
   CheckPermissionStatus(PermissionType::PROTECTED_MEDIA_IDENTIFIER,
                         PermissionStatus::ASK);
@@ skipping 258 matching lines @@
   CheckPermissionStatus(PermissionType::GEOLOCATION, PermissionStatus::ASK);
   GetHostContentSettingsMap()->SetContentSettingDefaultScope(
       url(), url(), CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string(),
       CONTENT_SETTING_ALLOW);
   CheckPermissionStatus(PermissionType::GEOLOCATION, PermissionStatus::GRANTED);
 
   EXPECT_FALSE(callback_called());
 
   GetPermissionManager()->UnsubscribePermissionStatusChange(subscription_id);
 }
+
+TEST_F(PermissionManagerTest, SuppressPermissionRequests) {
+  content::WebContents* contents = web_contents();
+  EXPECT_NE(kNoPendingOperation,
+            GetPermissionManager()->RequestPermission(
+                PermissionType::GEOLOCATION, web_contents()->GetMainFrame(),
+                url(), true,
+                base::Bind(&PermissionManagerTest::OnPermissionChange,
+                           base::Unretained(this))));
+
+#if BUILDFLAG(ENABLE_VR)
+  vr_shell::VrTabHelper* vr_tab_helper =
+      vr_shell::VrTabHelper::FromWebContents(contents);
+
+  vr_tab_helper->SetIsInVr(true);
+  EXPECT_EQ(kNoPendingOperation,
+            GetPermissionManager()->RequestPermission(
+                PermissionType::GEOLOCATION, web_contents()->GetMainFrame(),
+                url(), true,
+                base::Bind(&PermissionManagerTest::OnPermissionChange,
+                           base::Unretained(this))));
+
+  vr_tab_helper->SetIsInVr(false);
+  EXPECT_NE(kNoPendingOperation,
+            GetPermissionManager()->RequestPermission(
+                PermissionType::GEOLOCATION, web_contents()->GetMainFrame(),
+                url(), true,
+                base::Bind(&PermissionManagerTest::OnPermissionChange,
+                           base::Unretained(this))));

[raymes, 2017/05/30 00:32:32]

Please check callback_called() and callback_result() in both these cases

[asimjour1, 2017/05/30 18:27:45]

Done.

+#endif  // BUILDFLAG(ENABLE_VR)
+}