Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2904613002: Redo "dart2js: replace 'invariant' with 'failedAt' to defer interpolation" (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Redo "dart2js: replace 'invariant' with 'failedAt' to defer interpolation" TBR=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d2688c4ce6be00247f03ccd77c27e0b7f0d54633

Patch Set 1 #

Patch Set 2 : export failedAt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -94 lines) Patch
M pkg/compiler/lib/src/common.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/invariant.dart View 2 chunks +25 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 25 chunks +113 lines, -92 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
sra1
Committed patchset #2 (id:20001) manually as d2688c4ce6be00247f03ccd77c27e0b7f0d54633 (presubmit successful).
3 years, 7 months ago (2017-05-23 18:45:04 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-24 07:52:26 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698