third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp - Issue 2904603003: [IndexedDB] Adding txn, value, and key size metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

Issue 2904603003: [IndexedDB] Adding txn, value, and key size metrics (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

index e799703de7fdd455cf1246e44287fb97eba5a2ee..e268b527cf0406b565d8ae08ea023ad68538925b 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

@@ -511,6 +511,9 @@ IDBRequest* IDBObjectStore::put(ScriptState* script_state,

serialized_value->ToWireBytes(wire_bytes);

RefPtr<SharedBuffer> value_buffer = SharedBuffer::AdoptVector(wire_bytes);

+ UMA_HISTOGRAM_MEMORY_KB("WebCore.IndexedDB.PutValueSize",

+ value_buffer->size());

pwnall 2017/05/23 23:01:10 Could you please also UMA the number of Blobs atta

dmurph 2017/05/24 02:01:58 Done.

request->StorePutOperationBlobs(serialized_value->BlobDataHandles());

BackendDB()->Put(transaction_->Id(), Id(), WebData(value_buffer), blob_info,