Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp

Issue 2904563004: [ServiceWorker] Fix ExtendableMessageEvent idl binding (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp
index c37b239c6a0ff04ac4741b015bad1625000e90a8..1ec3cc1ac6c5d21594b912cd1bf19263b6d52e76 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp
@@ -51,24 +51,17 @@ ExtendableMessageEvent* ExtendableMessageEvent::Create(
return event;
}
-MessagePortArray ExtendableMessageEvent::ports(bool& is_null) const {
+MessagePortArray ExtendableMessageEvent::ports() const {
// TODO(bashi): Currently we return a copied array because the binding
// layer could modify the content of the array while executing JS callbacks.
// Avoid copying once we can make sure that the binding layer won't
// modify the content.
if (ports_) {
- is_null = false;
return *ports_;
}
- is_null = true;
return MessagePortArray();
}
-MessagePortArray ExtendableMessageEvent::ports() const {
- bool unused;
- return ports(unused);
-}
-
void ExtendableMessageEvent::source(
ClientOrServiceWorkerOrMessagePort& result) const {
if (source_as_client_)

Powered by Google App Engine
This is Rietveld 408576698