Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3915)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2904533002: Factor management of metrics updates into its own class. (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 29ce7bc4b0fcdad737f236eba370a5b5a615014b..b1875492bf751488a15cb85768142bc895efeada 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -609,13 +609,9 @@ void MetricsWebContentsObserver::OnTimingUpdated(
if (error)
return;
- const bool is_main_frame = (render_frame_host->GetParent() == nullptr);
- if (is_main_frame) {
- committed_load_->UpdateTiming(timing, metadata);
- } else {
- committed_load_->UpdateSubFrameTiming(render_frame_host, timing, metadata);
- }
+ committed_load_->UpdateTiming(render_frame_host, timing, metadata);
+ const bool is_main_frame = (render_frame_host->GetParent() == nullptr);
for (auto& observer : testing_observers_)
observer.OnTimingUpdated(is_main_frame, timing, metadata);
}

Powered by Google App Engine
This is Rietveld 408576698