Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3386)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2904533002: Factor management of metrics updates into its own class. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 29ce7bc4b0fcdad737f236eba370a5b5a615014b..072f1b510545a10a919d715471a2208a1e9ab919 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -15,6 +15,7 @@
#include "base/metrics/histogram_macros.h"
#include "chrome/browser/page_load_metrics/browser_page_track_decider.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
#include "chrome/browser/page_load_metrics/page_load_tracker.h"
#include "chrome/common/chrome_features.h"
@@ -326,6 +327,8 @@ void MetricsWebContentsObserver::DidFinishNavigation(
GetMainFrame(navigation_handle->GetParentFrame()) ==
web_contents()->GetMainFrame()) {
committed_load_->DidFinishSubFrameNavigation(navigation_handle);
+ committed_load_->metrics_update_dispatcher()->DidFinishSubFrameNavigation(
+ navigation_handle);
}
return;
}
@@ -609,13 +612,10 @@ void MetricsWebContentsObserver::OnTimingUpdated(
if (error)
return;
- const bool is_main_frame = (render_frame_host->GetParent() == nullptr);
- if (is_main_frame) {
- committed_load_->UpdateTiming(timing, metadata);
- } else {
- committed_load_->UpdateSubFrameTiming(render_frame_host, timing, metadata);
- }
+ committed_load_->metrics_update_dispatcher()->UpdateMetrics(render_frame_host,
+ timing, metadata);
+ const bool is_main_frame = (render_frame_host->GetParent() == nullptr);
for (auto& observer : testing_observers_)
observer.OnTimingUpdated(is_main_frame, timing, metadata);
}
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698