Issue 290453006: Quick & dirty example of a WebUIBrowserTest using LoginManagerTestHelper.

Issue 290453006: Quick & dirty example of a WebUIBrowserTest using LoginManagerTestHelper. (Closed)

Created:
6 years, 7 months ago by michaelpg

Modified:
5 years, 10 months ago

Reviewers:
Nikita (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Quick & dirty example of a WebUIBrowserTest using LoginManagerTestHelper.

Patch Set 2 : broken test #

Total comments: 6

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+579 lines, -197 lines)			Patch
M	chrome/browser/chromeos/login/login_manager_test.h	View	1	4 chunks	+15 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_manager_test.cc	View	1	2 chunks	+30 lines, -71 lines	0 comments	Download
A	chrome/browser/chromeos/login/login_manager_test_helper.h	View		1 chunk	+76 lines, -0 lines	0 comments	Download
A +	chrome/browser/chromeos/login/login_manager_test_helper.cc	View	1	4 chunks	+33 lines, -45 lines	0 comments	Download
A	chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.h	View	1	1 chunk	+92 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc	View	1	1 chunk	+153 lines, -70 lines	6 comments	Download
A	chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.js	View	1	1 chunk	+170 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

michaelpg

https://codereview.chromium.org/290453006/diff/20001/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc File chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc (right): https://codereview.chromium.org/290453006/diff/20001/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc#newcode94 chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc:94: // ExistingUserController. This is similar to what existing_user_controller_browsertest.cc does. ...

6 years, 7 months ago (2014-05-20 00:41:37 UTC) #1

Nikita (slow)

6 years, 7 months ago (2014-05-20 12:50:35 UTC) #2

https://codereview.chromium.org/290453006/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc
(right):

https://codereview.chromium.org/290453006/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc:127: //
login_manager_test_helper_->SetUpCommandLine(command_line);
On 2014/05/20 00:41:37, Michael Giuffrida wrote:
> This would add kLoginManager and kForceLoginManagerForTests, but that doesn't
> seem to be compatible with a WebUIBrowserTest because it just fails with no
> warning.

As far as I remember the issue with WebUIBrowserTest is that it setups mocks for
the handlers and we seems to require real handlers.

So WebUIBrowserTest might be not correct test paradigm when you
1. Want to configure system as close as possible to real one (register and login
users)
2. Then test WebUI

Expand Messages | Collapse Messages