chrome/browser/google/google_url_tracker.cc - Issue 290453005: Remove Infobars notifications from GoogleURLTrackerMapEntry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/google/google_url_tracker.cc

Issue 290453005: Remove Infobars notifications from GoogleURLTrackerMapEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/google/google_url_tracker.cc

diff --git a/chrome/browser/google/google_url_tracker.cc b/chrome/browser/google/google_url_tracker.cc

index 88233acf8c8ed808ae147740f927c99443cac6cd..986f471fad20624a603a3b70ccafd19858ab4f64 100644

--- a/chrome/browser/google/google_url_tracker.cc

+++ b/chrome/browser/google/google_url_tracker.cc

@@ -36,7 +36,6 @@ GoogleURLTracker::GoogleURLTracker(Profile* profile,

Mode mode)

: profile_(profile),

client_(client.Pass()),

- infobar_creator_(base::Bind(&GoogleURLTrackerInfoBarDelegate::Create)),

google_url_(mode == UNIT_TEST_MODE ?

kDefaultGoogleHomepage :

profile->GetPrefs()->GetString(prefs::kLastKnownGoogleURL)),

@@ -343,7 +342,7 @@ void GoogleURLTracker::OnNavigationCommitted(

if (map_entry->has_infobar_delegate()) {

map_entry->infobar_delegate()->Update(search_url);

} else {

- infobars::InfoBar* infobar = infobar_creator_.Run(

+ infobars::InfoBar* infobar = GoogleURLTrackerInfoBarDelegate::Create(

infobar_manager, this, search_url);

if (infobar) {

map_entry->SetInfoBarDelegate(