Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/google/google_url_tracker.h

Issue 290453005: Remove Infobars notifications from GoogleURLTrackerMapEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/google/google_url_tracker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_H_ 5 #ifndef CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_H_
6 #define CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_H_ 6 #define CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 bool must_be_listening_for_commit); 181 bool must_be_listening_for_commit);
182 182
183 void NotifyGoogleURLUpdated(GURL old_url, GURL new_url); 183 void NotifyGoogleURLUpdated(GURL old_url, GURL new_url);
184 184
185 CallbackList callback_list_; 185 CallbackList callback_list_;
186 186
187 Profile* profile_; 187 Profile* profile_;
188 188
189 scoped_ptr<GoogleURLTrackerClient> client_; 189 scoped_ptr<GoogleURLTrackerClient> client_;
190 190
191 // Creates an infobar and adds it to the provided InfoBarManager. Returns
192 // the infobar on success or NULL on failure. The caller does not own the
193 // returned object, the InfoBarManager does.
194 base::Callback<infobars::InfoBar*(infobars::InfoBarManager*,
195 GoogleURLTracker*,
196 const GURL&)> infobar_creator_;
197
198 GURL google_url_; 191 GURL google_url_;
199 GURL fetched_google_url_; 192 GURL fetched_google_url_;
200 scoped_ptr<net::URLFetcher> fetcher_; 193 scoped_ptr<net::URLFetcher> fetcher_;
201 int fetcher_id_; 194 int fetcher_id_;
202 bool in_startup_sleep_; // True if we're in the five-second "no fetching" 195 bool in_startup_sleep_; // True if we're in the five-second "no fetching"
203 // period that begins at browser start. 196 // period that begins at browser start.
204 bool already_fetched_; // True if we've already fetched a URL once this run; 197 bool already_fetched_; // True if we've already fetched a URL once this run;
205 // we won't fetch again until after a restart. 198 // we won't fetch again until after a restart.
206 bool need_to_fetch_; // True if a consumer actually wants us to fetch an 199 bool need_to_fetch_; // True if a consumer actually wants us to fetch an
207 // updated URL. If this is never set, we won't 200 // updated URL. If this is never set, we won't
208 // bother to fetch anything. 201 // bother to fetch anything.
209 // Consumers should register a callback via 202 // Consumers should register a callback via
210 // RegisterCallback(). 203 // RegisterCallback().
211 bool need_to_prompt_; // True if the last fetched Google URL is not 204 bool need_to_prompt_; // True if the last fetched Google URL is not
212 // matched with current user's default Google URL 205 // matched with current user's default Google URL
213 // nor the last prompted Google URL. 206 // nor the last prompted Google URL.
214 bool search_committed_; // True when we're expecting a notification of a new 207 bool search_committed_; // True when we're expecting a notification of a new
215 // pending search navigation. 208 // pending search navigation.
216 EntryMap entry_map_; 209 EntryMap entry_map_;
217 base::WeakPtrFactory<GoogleURLTracker> weak_ptr_factory_; 210 base::WeakPtrFactory<GoogleURLTracker> weak_ptr_factory_;
218 211
219 DISALLOW_COPY_AND_ASSIGN(GoogleURLTracker); 212 DISALLOW_COPY_AND_ASSIGN(GoogleURLTracker);
220 }; 213 };
221 214
222 #endif // CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_H_ 215 #endif // CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/google/google_url_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698