Revert of Move a good set of gfx unit tests into gfx_unittests target.

Revert of Move a good set of gfx unit tests into gfx_unittests target. (https://codereview.chromium.org/280973003/)

Reason for revert:
Speculative revert: Compilation appears broken on http://chromegw.corp.google.com/i/chromium.linux/builders/Linux%20Builder%20%28dbg%29 after this CL, with libgfx-related errors:

FAILED: /b/build/goma/gomacc c++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -L. -Wl,-uIsHeapProfilerRunning,-uProfilerStart -Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi -Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl -Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv -m64 -Wl,--icf=none -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o gfx_unittests -Wl,--start-group obj/ui/gfx/gfx_unittests.font_unittest.o obj/ui/gfx/image/gfx_unittests.image_family_unittest.o obj/ui/gfx/image/gfx_unittests.image_skia_unittest.o obj/ui/gfx/image/gfx_unittests.image_unittest.o obj/ui/gfx/image/gfx_unittests.image_unittest_util.o obj/ui/gfx/test/gfx_unittests.run_all_unittests.o obj/ui/gfx/gfx_unittests.text_elider_unittest.o obj/ui/gfx/gfx_unittests.text_utils_unittest.o obj/ui/gfx/animation/gfx_unittests.animation_container_unittest.o obj/ui/gfx/animation/gfx_unittests.animation_unittest.o obj/ui/gfx/animation/gfx_unittests.multi_animation_unittest.o obj/ui/gfx/animation/gfx_unittests.slide_animation_unittest.o obj/ui/gfx/animation/gfx_unittests.tween_unittest.o obj/ui/gfx/gfx_unittests.blit_unittest.o obj/ui/gfx/gfx_unittests.break_list_unittest.o obj/ui/gfx/codec/gfx_unittests.jpeg_codec_unittest.o obj/ui/gfx/codec/gfx_unittests.png_codec_unittest.o obj/ui/gfx/gfx_unittests.color_analysis_unittest.o obj/ui/gfx/gfx_unittests.color_utils_unittest.o obj/ui/gfx/gfx_unittests.display_unittest.o obj/ui/gfx/geometry/gfx_unittests.box_unittest.o obj/ui/gfx/geometry/gfx_unittests.cubic_bezier_unittest.o obj/ui/gfx/geometry/gfx_unittests.insets_unittest.o obj/ui/gfx/geometry/gfx_unittests.matrix3_unittest.o obj/ui/gfx/geometry/gfx_unittests.point_unittest.o obj/ui/gfx/geometry/gfx_unittests.point3_unittest.o obj/ui/gfx/geometry/gfx_unittests.quad_unittest.o obj/ui/gfx/geometry/gfx_unittests.r_tree_unittest.o obj/ui/gfx/geometry/gfx_unittests.rect_unittest.o obj/ui/gfx/geometry/gfx_unittests.safe_integer_conversions_unittest.o obj/ui/gfx/geometry/gfx_unittests.size_unittest.o obj/ui/gfx/geometry/gfx_unittests.vector2d_unittest.o obj/ui/gfx/geometry/gfx_unittests.vector3d_unittest.o obj/ui/gfx/image/gfx_unittests.image_util_unittest.o obj/ui/gfx/range/gfx_unittests.range_unittest.o obj/ui/gfx/gfx_unittests.sequential_id_generator_unittest.o obj/ui/gfx/gfx_unittests.shadow_value_unittest.o obj/ui/gfx/gfx_unittests.skbitmap_operations_unittest.o obj/ui/gfx/gfx_unittests.skrect_conversion_unittest.o obj/ui/gfx/gfx_unittests.transform_util_unittest.o obj/ui/gfx/gfx_unittests.utf16_indexing_unittest.o obj/ui/gfx/gfx_unittests.transform_unittest.o obj/ui/gfx/gfx_unittests.interpolated_transform_unittest.o obj/ui/gfx/gfx_unittests.platform_font_pango_unittest.o obj/base/libtest_support_base.a obj/testing/libgtest.a obj/third_party/libpng/libpng.a obj/ui/gfx/libgfx_test_support.a obj/base/allocator/liballocator.a obj/base/libbase_static.a obj/testing/libgmock.a obj/third_party/libxml/libxml2.a obj/third_party/zlib/libchrome_zlib.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a lib/libui_base.so lib/libgfx.so lib/libicuuc.so lib/libskia.so lib/libbase.so lib/libgfx_geometry.so lib/libbase_i18n.so -Wl,--end-group -lrt -ldl -lfontconfig -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lfreetype -lgobject-2.0 -lglib-2.0
lib/libgfx.so:error: undefined reference to 'XCreateRegion'
lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
lib/libgfx.so:error: undefined reference to 'XPolygonRegion'
collect2: ld returned 1 exit status

Original issue's description:
> Move a good set of gfx unit tests into gfx_unittests target.
> 
> This requires to major changes:
> 
> 1- It requires the introduction of GfxTestSuite to allow us to
> initialize the ResourceBundle which is required for some of these tests
> to pass.
> 2- It requires to split gfx_unittests target out of gfx.gyp, into
> gfx_tests.gyp. This is necessary because otherwise a circular dependency
> between ui_base.gyp and gfx.gyp would arise.
> 
> The circular dependency is the form of:
> gfx.gyp -> ui_base.gyp -> gfx.gyp
> 
> And is created because gfx_unittests now requires ResourceBundle to link
> which is in ui_base target.
> 
> BUG=331829
> TEST=ui_unittests,gfx_unittests
> R=danakj@chromium.org
> TBR=ben@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270586

TBR=ben@chromium.org,danakj@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331829
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270600

[vabr (Chromium), 2014-05-15 06:34:55]

Created Revert of Move a good set of gfx unit tests into gfx_unittests target.

[commit-bot: I haz the power, 2014-05-15 06:39:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vabr@chromium.org/290453002/1

[commit-bot: I haz the power, 2014-05-15 06:45:05]

Change committed as 270600

[vabr (Chromium), 2014-05-15 07:12:22]

The compilation was fixed by this revert on
http://chromegw.corp.google.com/i/chromium.linux/builders/Linux%20Builder%20%...,
so I'm keeping it.

[tfarina, 2014-05-21 03:24:12]

Vabr, which trybot corresponds to this configuration.

I'm not able to reproduce this locally in a clobber build nor any of the default
set of trybots.

I'm trying to reland this at https://codereview.chromium.org/291753002/

[vabr (Chromium), 2014-05-21 07:33:33]

On 2014/05/21 03:24:12, tfarina wrote:
> Vabr, which trybot corresponds to this configuration.
> 
> I'm not able to reproduce this locally in a clobber build nor any of the
default
> set of trybots.
> 
> I'm trying to reland this at https://codereview.chromium.org/291753002/

Hi tfarina@,

I'm not sure which trybot corresponds to the build bot Linux Builder (dbg), on
which this failed originally.
Relanding sounds reasonable if you cannot reproduce otherwise, but please keep
an eye on the buildbots after you land.

Thanks,
Vaclav

[tfarina, 2014-05-22 04:45:31]

On 2014/05/21 07:33:33, vabr (Chromium) wrote:
> On 2014/05/21 03:24:12, tfarina wrote:
> > Vabr, which trybot corresponds to this configuration.
> > 
> > I'm not able to reproduce this locally in a clobber build nor any of the
> default
> > set of trybots.
> > 
> > I'm trying to reland this at https://codereview.chromium.org/291753002/
> 
> Hi tfarina@,
> 
> I'm not sure which trybot corresponds to the build bot Linux Builder (dbg), on
> which this failed originally.
> Relanding sounds reasonable if you cannot reproduce otherwise, but please keep
> an eye on the buildbots after you land.
>
I have relanded it.

Linux Builder (dbg) looks green.
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builde...

I have alerted the sheriffs on #chromium to revert it in case it breaks
compilation again.

It is looking promising this time though.

(I hope I won't see it reverted when I wake up tomorrow).