Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart

Issue 2904493002: Use KernelToElementMap (more) directly in KernelSsaBuilder (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder_kernel.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart b/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
index 0ff8608bf617171d6cc20719247e30eaea068c45..ae96cc34040dee7f918c2edbea6254abaef52330 100644
--- a/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart
@@ -25,7 +25,6 @@ import '../tree/tree.dart' as ast;
import '../types/masks.dart';
import '../types/types.dart';
import '../universe/selector.dart';
-import '../universe/side_effects.dart';
import '../world.dart';
import 'graph_builder.dart';
import 'jump_handler.dart' show SwitchCaseJumpHandler;
@@ -231,18 +230,9 @@ class KernelAstAdapter extends KernelToElementMapMixin {
return getElement(variable) as LocalElement;
}
- bool getCanThrow(ir.Node procedure, ClosedWorld closedWorld) {
- FunctionElement function = getElement(procedure);
- return !closedWorld.getCannotThrow(function);
- }
-
- TypeMask returnTypeOf(ir.Procedure node) {
+ TypeMask getReturnTypeOf(FunctionEntity function) {
return TypeMaskFactory.inferredReturnTypeForElement(
- getMethod(node), _globalInferenceResults);
- }
-
- SideEffects getSideEffects(ir.Node node, ClosedWorld closedWorld) {
- return closedWorld.getSideEffectsOfElement(getElement(node));
+ function, _globalInferenceResults);
}
FunctionSignature getFunctionSignature(ir.FunctionNode function) {
@@ -331,9 +321,9 @@ class KernelAstAdapter extends KernelToElementMapMixin {
typeOfIterator(forInStatement), _globalInferenceResults);
}
- TypeMask inferredTypeOf(ir.Member node) {
+ TypeMask getInferredTypeOf(MemberEntity member) {
return TypeMaskFactory.inferredTypeForMember(
- getMember(node), _globalInferenceResults);
+ member, _globalInferenceResults);
}
TypeMask selectorTypeOf(Selector selector, TypeMask mask) {
@@ -400,135 +390,6 @@ class KernelAstAdapter extends KernelToElementMapMixin {
});
}
- ir.Procedure get checkDeferredIsLoaded =>
- kernel.functions[_compiler.commonElements.checkDeferredIsLoaded];
-
- TypeMask get checkDeferredIsLoadedType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.checkDeferredIsLoaded,
- _globalInferenceResults);
-
- ir.Procedure get createInvocationMirror =>
- kernel.functions[_compiler.commonElements.createInvocationMirror];
-
- ir.Class get mapLiteralClass =>
- kernel.classes[_compiler.commonElements.mapLiteralClass];
-
- ir.Procedure get mapLiteralConstructor =>
- kernel.functions[_compiler.commonElements.mapLiteralConstructor];
-
- ir.Procedure get mapLiteralConstructorEmpty =>
- kernel.functions[_compiler.commonElements.mapLiteralConstructorEmpty];
-
- ir.Procedure get mapLiteralUntypedEmptyMaker =>
- kernel.functions[_compiler.commonElements.mapLiteralUntypedEmptyMaker];
-
- ir.Procedure get exceptionUnwrapper =>
- kernel.functions[_compiler.commonElements.exceptionUnwrapper];
-
- TypeMask get exceptionUnwrapperType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.exceptionUnwrapper, _globalInferenceResults);
-
- ir.Procedure get traceFromException =>
- kernel.functions[_compiler.commonElements.traceFromException];
-
- TypeMask get traceFromExceptionType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.traceFromException, _globalInferenceResults);
-
- ir.Procedure get streamIteratorConstructor =>
- kernel.functions[_compiler.commonElements.streamIteratorConstructor];
-
- TypeMask get streamIteratorConstructorType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- // ignore: UNNECESSARY_CAST
- _compiler.commonElements.streamIteratorConstructor as FunctionEntity,
- _globalInferenceResults);
-
- ir.Procedure get fallThroughError =>
- kernel.functions[_compiler.commonElements.fallThroughError];
-
- TypeMask get fallThroughErrorType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.fallThroughError, _globalInferenceResults);
-
- ir.Procedure get mapLiteralUntypedMaker =>
- kernel.functions[_compiler.commonElements.mapLiteralUntypedMaker];
-
- ir.Procedure get checkConcurrentModificationError => kernel
- .functions[_compiler.commonElements.checkConcurrentModificationError];
-
- TypeMask get checkConcurrentModificationErrorReturnType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.checkConcurrentModificationError,
- _globalInferenceResults);
-
- ir.Procedure get checkSubtype =>
- kernel.functions[_compiler.commonElements.checkSubtype];
-
- ir.Procedure get checkSubtypeOfRuntimeType =>
- kernel.functions[_compiler.commonElements.checkSubtypeOfRuntimeType];
-
- ir.Procedure get functionTypeTest =>
- kernel.functions[_compiler.commonElements.functionTypeTest];
-
- ir.Procedure get throwTypeError =>
- kernel.functions[_compiler.commonElements.throwTypeError];
-
- TypeMask get throwTypeErrorType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.throwTypeError, _globalInferenceResults);
-
- ir.Procedure get assertHelper =>
- kernel.functions[_compiler.commonElements.assertHelper];
-
- TypeMask get assertHelperReturnType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.assertHelper, _globalInferenceResults);
-
- ir.Procedure get assertTest =>
- kernel.functions[_compiler.commonElements.assertTest];
-
- TypeMask get assertTestReturnType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.assertTest, _globalInferenceResults);
-
- ir.Procedure get assertThrow =>
- kernel.functions[_compiler.commonElements.assertThrow];
-
- ir.Procedure get setRuntimeTypeInfo =>
- kernel.functions[_compiler.commonElements.setRuntimeTypeInfo];
-
- TypeMask get assertThrowReturnType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.assertThrow, _globalInferenceResults);
-
- ir.Procedure get runtimeTypeToString =>
- kernel.functions[_compiler.commonElements.runtimeTypeToString];
-
- ir.Procedure get createRuntimeType =>
- kernel.functions[_compiler.commonElements.createRuntimeType];
-
- TypeMask get createRuntimeTypeReturnType =>
- TypeMaskFactory.inferredReturnTypeForElement(
- _compiler.commonElements.createRuntimeType, _globalInferenceResults);
-
- ir.Class get objectClass =>
- kernel.classes[_compiler.commonElements.objectClass];
-
- ir.Class get futureClass =>
- kernel.classes[_compiler.commonElements.futureClass];
-
- TypeMask makeSubtypeOfObject(ClosedWorld closedWorld) =>
- new TypeMask.subclass(_compiler.commonElements.objectClass, closedWorld);
-
- ir.Procedure get currentIsolate =>
- kernel.functions[_compiler.commonElements.currentIsolate];
-
- ir.Procedure get callInIsolate =>
- kernel.functions[_compiler.commonElements.callInIsolate];
-
bool isInForeignLibrary(ir.Member member) =>
_backend.isForeign(getElement(member));
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder_kernel.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698