Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: apps/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/BUILD.gn
diff --git a/apps/BUILD.gn b/apps/BUILD.gn
index fae99193fa0d25e67101b71bb21c38df9f150879..00e95f3a10cf141935aeca8e3b68309aabd77602 100644
--- a/apps/BUILD.gn
+++ b/apps/BUILD.gn
@@ -7,47 +7,47 @@ import("//build/config/ui.gni")
import("//extensions/features/features.gni")
assert(!is_android && !is_ios)
+assert(enable_extensions,
+ "Cannot depend on extensions because enable_extensions=false.")
static_library("apps") {
sources = []
- if (enable_extensions) {
- sources += [
- "app_lifetime_monitor.cc",
- "app_lifetime_monitor.h",
- "app_lifetime_monitor_factory.cc",
- "app_lifetime_monitor_factory.h",
- "app_restore_service.cc",
- "app_restore_service.h",
- "app_restore_service_factory.cc",
- "app_restore_service_factory.h",
- "browser_context_keyed_service_factories.cc",
- "browser_context_keyed_service_factories.h",
- "launcher.cc",
- "launcher.h",
- "metrics_names.h",
- "saved_files_service.cc",
- "saved_files_service.h",
- "saved_files_service_factory.cc",
- "saved_files_service_factory.h",
- "switches.cc",
- "switches.h",
- ]
+ sources += [
+ "app_lifetime_monitor.cc",
+ "app_lifetime_monitor.h",
+ "app_lifetime_monitor_factory.cc",
+ "app_lifetime_monitor_factory.h",
+ "app_restore_service.cc",
+ "app_restore_service.h",
+ "app_restore_service_factory.cc",
+ "app_restore_service_factory.h",
+ "browser_context_keyed_service_factories.cc",
+ "browser_context_keyed_service_factories.h",
+ "launcher.cc",
+ "launcher.h",
+ "metrics_names.h",
+ "saved_files_service.cc",
+ "saved_files_service.h",
+ "saved_files_service_factory.cc",
+ "saved_files_service_factory.h",
+ "switches.cc",
+ "switches.h",
+ ]
- configs += [ "//build/config/compiler:wexit_time_destructors" ]
+ configs += [ "//build/config/compiler:wexit_time_destructors" ]
- deps = [
- "//components/keyed_service/content",
- "//content/public/browser",
- "//content/public/common",
- "//extensions/browser",
- "//extensions/common",
- "//extensions/common/api",
- ]
+ deps = [
+ "//components/keyed_service/content",
+ "//content/public/browser",
+ "//content/public/common",
+ "//extensions/browser",
+ "//extensions/common",
+ "//extensions/common/api",
+ ]
- if (is_chromeos) {
- deps += [ "//components/user_manager" ]
- }
+ if (is_chromeos) {
+ deps += [ "//components/user_manager" ]
}
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698