Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Fix error from "gn gen out --check" Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/BUILD.gn
diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn
index 8bf047e182127cb07a00a23f3be9a0f45238d992..790bff2b885c1e93e99e2d76784cbbd8de7b7125 100644
--- a/chrome/browser/devtools/BUILD.gn
+++ b/chrome/browser/devtools/BUILD.gn
@@ -73,12 +73,16 @@ static_library("devtools") {
"//chrome:strings",
"//chrome/app/theme:theme_resources",
"//chrome/common",
- "//chrome/common/extensions/api",
"//net:http_server",
"//skia",
"//third_party/icu",
"//third_party/leveldatabase",
]
+
+ if (enable_extensions) {
+ deps += [ "//chrome/common/extensions/api" ]
michaelpg 2017/05/23 16:54:40 I don't see includes of this dir in c/b/devtools.
+ }
+
sources += [
"chrome_devtools_manager_delegate.cc",
"chrome_devtools_manager_delegate.h",

Powered by Google App Engine
This is Rietveld 408576698